FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor(Modal): Simplify disabling of FocusTrap by Venefilyn · Pull Request #2862 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

refactor(Modal): Simplify disabling of FocusTrap - #2862

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
Venefilyn:refactor/modal-focustrap
Sep 19, 2019
ConversationCommits (1)ChecksFiles changed
Merged

refactor(Modal): Simplify disabling of FocusTrap#2862
tlabaj merged 1 commit into
patternfly:masterfrom
Venefilyn:refactor/modal-focustrap

Conversation

Venefilyn commented Sep 6, 2019 •
edited by tlabaj
Loading

Copy link
Copy Markdown
Contributor

What: This removes complexity and uses FocusTrapReact's active prop instead of switching to Bullseye component

Additional issues: #2966

patternfly-build commented Sep 6, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2862.surge.sh

redallen approved these changes Sep 6, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Modal/ModalContent.tsx
{modalBox}
</FocusTrap>
)}
<FocusTrap active={!disableFocusTrap} focusTrapOptions={{ clickOutsideDeactivates: true }} className={css(styles.bullseye)}>

redallen Sep 6, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Neat active property!

tlabaj added the PF4 label Sep 9, 2019
tlabaj requested a review from mcoker September 9, 2019 19:19
tlabaj reviewed Sep 9, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you please link the corresponding issue?

Venefilyn commented Sep 9, 2019

Copy link
Copy Markdown
Contributor Author

@tlabaj there's no corresponding issue. I was looking at a different component that uses FocusTrap and just wanted to clean the code up for Modal

jenny-s51 approved these changes Sep 13, 2019
View reviewed changes

jenny-s51 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice fix!

mcoker approved these changes Sep 17, 2019
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm!

tlabaj commented Sep 18, 2019

Copy link
Copy Markdown
Contributor

Looks great @spytec! We do require a corresponding issue to be linked before we merge a PR. I would be happy to open one for you if you would like.

tlabaj merged commit 2ca0bec into patternfly:master Sep 19, 2019
tlabaj mentioned this pull request Sep 19, 2019
Closed
Venefilyn deleted the refactor/modal-focustrap branch November 13, 2024 12:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcoker mcoker approved these changes
+3 more reviewers
tlabaj tlabaj left review comments
jenny-s51 jenny-s51 approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

dlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL