fix(FormGroup): Add className to element if not inline - #2864
Merged
tlabaj merged 1 commit intoSep 10, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2864.surge.sh |
Sorry, something went wrong.
redallen
approved these changes
Sep 6, 2019
redallen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice catch!
Sorry, something went wrong.
tlabaj
approved these changes
Sep 10, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: This fixes a regression from the conversion to TypeScript. The className prop is now correctly added to the root element
Regressed line: https://github.com/patternfly/patternfly-react/pull/1933/files#diff-f425f61f010b4c0b3170c953c332aba4L56
Additional issues: fixes #2855
cc @keithjgrant