FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(chipgroup): allow chipgroup toolbar item to handle single chip by jessiehuff · Pull Request #2882 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(chipgroup): allow chipgroup toolbar item to handle single chip - #2882

Merged
tlabaj merged 2 commits into
patternfly:masterfrom
jessiehuff:fix/chipgroupToolbarItem
Sep 17, 2019
ConversationCommits (2)ChecksFiles changed
Merged

fix(chipgroup): allow chipgroup toolbar item to handle single chip#2882
tlabaj merged 2 commits into
patternfly:masterfrom
jessiehuff:fix/chipgroupToolbarItem

Conversation

jessiehuff commented Sep 6, 2019

Copy link
Copy Markdown
Contributor

Fixes #2866

patternfly-build commented Sep 6, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2882.surge.sh

kmcfaul previously approved these changes Sep 9, 2019
View reviewed changes

karelhala commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Codewise looks good, but visualy it looks kinda off.

jessiehuff commented Sep 12, 2019

Copy link
Copy Markdown
Contributor Author

@karelhala Nice catch!! :) I think I fixed it.

karelhala previously approved these changes Sep 12, 2019
View reviewed changes

karelhala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah! Looks much better.

tlabaj approved these changes Sep 13, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

kmcfaul previously approved these changes Sep 13, 2019
View reviewed changes
tlabaj previously approved these changes Sep 17, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jessiehuff dismissed stale reviews from tlabaj, kmcfaul, and karelhala via 16eb096 September 17, 2019 14:17
jessiehuff force-pushed the fix/chipgroupToolbarItem branch from da41cdb to 16eb096 Compare September 17, 2019 14:17
tlabaj self-assigned this Sep 17, 2019
tlabaj approved these changes Sep 17, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 3d9881f into patternfly:master Sep 17, 2019

patternfly-build commented Sep 17, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.104.4
  • @patternfly/react-docs@4.13.6
  • @patternfly/react-inline-edit-extension@2.11.40
  • demo-app-ts@3.0.3
  • @patternfly/react-table@2.20.20
  • @patternfly/react-topology@2.8.38
  • @patternfly/react-virtualized-extension@1.2.28

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kmcfaul kmcfaul approved these changes
+2 more reviewers
tlabaj tlabaj approved these changes
karelhala karelhala left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

tlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ChipGroupToolbarItem can't handle a single Chip

5 participants

Back | FazBrowse Home | New Git URL