Chart: New symbol for threshold - #2884
Merged
jschuler merged 1 commit intoSep 10, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2884.surge.sh |
Sorry, something went wrong.
dlabrecq
marked this pull request as ready for review
September 9, 2019 13:50
priley86
approved these changes
Sep 9, 2019
dlabrecq
force-pushed
the
dash-threshold
branch
from
a1e4764 to
4b8dc05
Compare
September 9, 2019 14:32
jenny-s51
self-requested a review
September 9, 2019 19:28
jenny-s51
approved these changes
Sep 9, 2019
jenny-s51
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
jschuler
approved these changes
Sep 10, 2019
Copy link
Copy Markdown
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a new legend symbol for thresholds (i.e., horizontal indicators). This is slightly different than the existing dash symbol, which is typically used to show differences between current and previous data, where the dashed symbol represents previous data.
This is to help fix: #2797
Also see: #2796
New threshold sybmol
Existing dash symbol
