Add line border to ChartArea and move sparkline - #2887
Merged
redallen merged 3 commits intoSep 13, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2887.surge.sh |
Sorry, something went wrong.
mcarrano
approved these changes
Sep 11, 2019
mcarrano
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good to me
Sorry, something went wrong.
mcarrano
approved these changes
Sep 11, 2019
mcarrano
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Still looks good
Sorry, something went wrong.
mceledonia
approved these changes
Sep 11, 2019
mceledonia
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Looking good!
Sorry, something went wrong.
dlabrecq
force-pushed
the
2843-sparkline
branch
from
bab5c35 to
29eaaf3
Compare
September 13, 2019 04:11
redallen
approved these changes
Sep 13, 2019
Copy link
Copy Markdown
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 more reviewers6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a line border to area charts and moves Sparkline to its own example, per design's request. Reviewed line border changes with @mceledonia
Fixes #2843
Area Charts
Sparkline Charts
