| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
PatternFly-React preview: https://patternfly-react-pr-2890.surge.sh |
Sorry, something went wrong.
| isDisabled: boolean; | ||
| disabled: boolean; | ||
| isHovered: boolean; | ||
| ref: React.RefObject<any>; |
There was a problem hiding this comment.
Changing this type here wont break anyone?
Sorry, something went wrong.
There was a problem hiding this comment.
The refs are used internally so I don't think it should
Sorry, something went wrong.
|
Waiting on the commit to set the autofocus based on keyboard entry opposed to all the time, but everything else is looking good! |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM - from an accessibility standpoint, keyboard functionality and voiceover work as expected after Jenn and I tested it. :)
Sorry, something went wrong.
There was a problem hiding this comment.
This looks fine as far as I can tell.
Sorry, something went wrong.
There was a problem hiding this comment.
Nice! this is really good adition and will help us a lot!
Sorry, something went wrong.
There was a problem hiding this comment.
Looks great!
Sorry, something went wrong.
There was a problem hiding this comment.
Still looking awesome!
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Closes: #2675
Keyboard navigation triggers on the <li> items now so that any custom node passed into <DropdownItem> can work without trowing errors.
Example:

Code:
render() { const { isOpen } = this.state; const dropdownItems = [ <DropdownItem key="action"> Default </DropdownItem>, <DropdownItem> <FormattedMessage id="welcome" defaultMessage={`Hello {name}, you have {unreadCount, number} {unreadCount, plural, one {message} other {messages} }`} values={{name: <b>Joachim</b>, unreadCount: 25}} /> </DropdownItem>, <DropdownItem key="action" component="button"> Render as button </DropdownItem>, <DropdownItem key="link"><Button>Use Button component</Button></DropdownItem>, <DropdownItem key="disabled link"> <Alert title="Use Alert component" /> </DropdownItem>, <DropdownItem key="disabled action" isDisabled component="button"> Disabled Action </DropdownItem>, <DropdownSeparator key="separator" />, <DropdownItem key="separated link">Separated Link</DropdownItem>, <DropdownItem key="separated action" component="button"> Separated Action </DropdownItem> ]; return ( <IntlProvider locale="en"> <Dropdown onSelect={this.onSelect} toggle={<DropdownToggle onToggle={this.onToggle} iconComponent={CaretDownIcon}>Dropdown</DropdownToggle>} isOpen={isOpen} dropdownItems={dropdownItems} /> </IntlProvider> ); }