FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(deps): bump PF3 deps by redallen · Pull Request #2895 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(deps): bump PF3 deps - #2895

Merged
jeff-phillips-18 merged 11 commits into
patternfly:masterfrom
redallen:chore/security-deps
Sep 25, 2019
ConversationCommits (11)ChecksFiles changed
Merged

chore(deps): bump PF3 deps#2895
jeff-phillips-18 merged 11 commits into
patternfly:masterfrom
redallen:chore/security-deps

Conversation

redallen commented Sep 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: Bump our version of PF3 core. Bump version of Storybook and fix its webpack config. Use a consistent version of lodash that's up to date. Closes #2889. Closes #2906.

Additional issues: The security tab of Github (and the workings of npm audit) is complicated. Outstanding vulnerabilities actually exported to our static sites should all be closed as a part of this PR.

patternfly-build commented Sep 12, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2895.surge.sh

dlabaj reviewed Sep 17, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Few comments, other then that it looks good.

Comment thread package.json
"start:pf3": "concurrently \"yarn storybook\" \"yarn storybook:openurl\"",
"start:pf3": "yarn storybook",
"start:pf4": "yarn build:pf4 && lerna run develop --parallel --stream",
"storybook:openurl": "node ./storybook/openBrowser.js",

dlabaj Sep 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this not needed anymore?

redallen Sep 17, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nope, the new storybook opens by itself and prints a message to the console with the link.

Comment thread storybook/webpack.config.js Outdated
};

return defaultConfig;
console.log('config', config.module.rules)

dlabaj Sep 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do we need to log this ... can it be removed.

redallen Sep 17, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch, thanks.

tlabaj requested a review from jschuler September 17, 2019 14:31
tlabaj mentioned this pull request Sep 17, 2019
Closed
redallen force-pushed the chore/security-deps branch 5 times, most recently from 82e0628 to 3c9f1e6 Compare September 20, 2019 18:23
dlabaj previously approved these changes Sep 23, 2019
View reviewed changes

dlabaj commented Sep 23, 2019

Copy link
Copy Markdown
Contributor

@redallen Looks like the build is failing.

dlabaj previously approved these changes Sep 24, 2019
View reviewed changes
jcaianirh previously approved these changes Sep 24, 2019
View reviewed changes

jcaianirh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

redallen dismissed stale reviews from jcaianirh and dlabaj via 74b6ac2 September 24, 2019 20:28

redallen commented Sep 24, 2019

Copy link
Copy Markdown
Contributor Author

@dlabaj @tlabaj Can we get this in before we merge anything else? Any change will cause conflicts.

jeff-phillips-18 merged commit 8995b2b into patternfly:master Sep 25, 2019
redallen mentioned this pull request Sep 25, 2019
Closed

patternfly-build commented Sep 25, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • patternfly-react-extensions@2.20.7
  • patternfly-react-wooden-tree@2.0.4
  • patternfly-react@2.39.2
  • @patternfly/react-console@1.12.11
  • @patternfly/react-charts@5.0.11
  • @patternfly/react-core@3.105.2
  • @patternfly/react-docs@4.13.17
  • @patternfly/react-inline-edit-extension@2.11.53
  • demo-app-ts@3.2.2
  • @patternfly/react-integration@3.2.1
  • @patternfly/react-styled-system@3.6.38
  • @patternfly/react-table@2.22.2
  • @patternfly/react-topology@2.8.49
  • @patternfly/react-virtualized-extension@1.2.39

Thanks for your contribution! 🎉

mturley mentioned this pull request Sep 25, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
jschuler Awaiting requested review from jschuler
+2 more reviewers
seanforyou23 seanforyou23 approved these changes
jcaianirh jcaianirh left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

dlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Security alerts showing up in product repos Update dependencies

7 participants

Back | FazBrowse Home | New Git URL