FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix live edit caret color so it is visible by TheRealJon · Pull Request #2899 · patternfly/patternfly-react · GitHub

Fix live edit caret color so it is visible - #2899

Merged
redallen merged 1 commit into
patternfly:masterfrom
TheRealJon:live-edit-cursor
Sep 13, 2019
Merged

Fix live edit caret color so it is visible#2899
redallen merged 1 commit into
patternfly:masterfrom
TheRealJon:live-edit-cursor

Conversation

TheRealJon commented Sep 10, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

What:

Live editor caret was invisible since it was the same color as the background. Changed to white so that it is visible against the black background.

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2899.surge.sh

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One line that will save every dev's life.

Copy link
Copy Markdown
Contributor Author

@redallen @jschuler Who wants to press the big green button?

Copy link
Copy Markdown
Contributor

The repo is frozen now, but we'll click it real soon :)

redallen merged commit 1a6d7b5 into patternfly:master Sep 13, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@4.9.11
  • @patternfly/react-docs@4.13.1
  • demo-app-ts@2.24.9
  • @patternfly/react-integration@2.24.1

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL