feat(Tab): Added two new props: mountOnEnter and unmountOnExit - #2902
Merged
dlabaj merged 2 commits intoSep 23, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2902.surge.sh |
Sorry, something went wrong.
tlabaj
suggested changes
Sep 17, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Can you add some integration test to verify these cahnges
Sorry, something went wrong.
dlabaj
reviewed
Sep 17, 2019
dlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good just one comment.
Sorry, something went wrong.
When mountOnEnter is provided as a prop, TabContents will mount on the DOM as you click the corresponding tab. When unmountONExit is provided, TabContents will unmount from the DOM when no longer visible. Fixes #2609
Copy link
Copy Markdown
Member
Author
|
Added integration test and changed from null to undefined. Also fixed minor bug in Tabs where you couldn't actually apply an id to the main Tabs div. |
Sorry, something went wrong.
dlabrecq
reviewed
Sep 18, 2019
Comment thread
packages/patternfly-4/react-core/src/components/Tabs/Tabs.tsx
Outdated
Prior to bugfix, you couldn't add an id to a Tabs divs.
dlabrecq
approved these changes
Sep 21, 2019
tlabaj
approved these changes
Sep 23, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
dlabaj
approved these changes
Sep 23, 2019
7 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When mountOnEnter is provided as a prop, TabContents will mount on the DOM as you click the corresponding tab. When unmountOnExit is provided, TabContents will unmount from the DOM when no longer visible.
Fixes #2609 and #1448.