FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(copyclipboard): add prop for expanded by default by christiemolloy · Pull Request #2923 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(copyclipboard): add prop for expanded by default - #2923

Merged
tlabaj merged 6 commits into
patternfly:masterfrom
christiemolloy:clipboardExpand
Sep 19, 2019
ConversationCommits (6)ChecksFiles changed
Merged

fix(copyclipboard): add prop for expanded by default#2923
tlabaj merged 6 commits into
patternfly:masterfrom
christiemolloy:clipboardExpand

Conversation

christiemolloy commented Sep 13, 2019

Copy link
Copy Markdown
Member

closes #2886

christiemolloy mentioned this pull request Sep 13, 2019
Closed

patternfly-build commented Sep 13, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2923.surge.sh

jenny-s51 previously approved these changes Sep 13, 2019
View reviewed changes

jenny-s51 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 🙂

tlabaj suggested changes Sep 17, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you also update the integration up so it use this prop and update the cypress test.

Comment thread packages/patternfly-4/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx
/** Flag to show if the input is read only. */
isReadOnly?: boolean;
/** Flag to determine if clipboard copy is in the expanded state initially */
isExpanded?: boolean;

tlabaj Sep 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

you need to add a default for this prop in 'defaultProps`

tlabaj self-assigned this Sep 17, 2019
tlabaj approved these changes Sep 19, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great!

tlabaj merged commit 8cd5d13 into patternfly:master Sep 19, 2019

patternfly-build commented Sep 19, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.104.7
  • @patternfly/react-docs@4.13.9
  • @patternfly/react-inline-edit-extension@2.11.43
  • demo-app-ts@3.0.6
  • @patternfly/react-integration@3.0.1
  • @patternfly/react-table@2.20.23
  • @patternfly/react-topology@2.8.41
  • @patternfly/react-virtualized-extension@1.2.31

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+3 more reviewers
boaz0 boaz0 approved these changes
tlabaj tlabaj approved these changes
jenny-s51 jenny-s51 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

tlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Option/Prop to add to Clipboard copy so that its expanded by default

6 participants

Back | FazBrowse Home | New Git URL