FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Table): add flag to hide select all by kmcfaul · Pull Request #2926 · patternfly/patternfly-react · GitHub

feat(Table): add flag to hide select all - #2926

Merged
redallen merged 5 commits into
patternfly:masterfrom
kmcfaul:table-select-all-toggle
Sep 20, 2019
Merged

feat(Table): add flag to hide select all#2926
redallen merged 5 commits into
patternfly:masterfrom
kmcfaul:table-select-all-toggle

Conversation

kmcfaul commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

What:

Additional issues: #2876

kmcfaul requested a review from priley86 September 13, 2019 18:56

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2926.surge.sh

karelhala previously approved these changes Sep 17, 2019

karelhala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looking good. Easy and straight forward solution.

priley86 previously approved these changes Sep 19, 2019
tlabaj previously requested changes Sep 19, 2019

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add a demo to the integration app for this.

jessiehuff previously approved these changes Sep 20, 2019

jessiehuff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM :)

kmcfaul dismissed stale reviews from jessiehuff, priley86, and karelhala via 36e98ea September 20, 2019 13:40
kmcfaul force-pushed the table-select-all-toggle branch from 36e98ea to 868af7a Compare September 20, 2019 14:30
redallen dismissed tlabaj’s stale review September 20, 2019 15:16

Test has been added.

redallen merged commit 419b6ff into patternfly:master Sep 20, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-inline-edit-extension@2.11.49
  • demo-app-ts@3.1.0
  • @patternfly/react-integration@3.1.0
  • @patternfly/react-table@2.21.0

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL