FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Cards): refactor sub-component references by sjd78 · Pull Request #2935 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Cards): refactor sub-component references - #2935

Merged
dlabrecq merged 1 commit into
patternfly:masterfrom
sjd78:pf3-card-tree-shaking
Oct 16, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(Cards): refactor sub-component references#2935
dlabrecq merged 1 commit into
patternfly:masterfrom
sjd78:pf3-card-tree-shaking

Conversation

sjd78 commented Sep 16, 2019

Copy link
Copy Markdown
Member

Due to #2931, rearrange the way Card includes the component's sub-components to match the way the Wizard (and all other components) does it. The new style will allow the sub-component references to survive webpack tree shaking.

patternfly-build commented Sep 16, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2935.surge.sh

tlabaj added the PF3 label Sep 17, 2019

kmcfaul commented Sep 23, 2019

Copy link
Copy Markdown
Contributor

Looks like tests may have to be updated, otherwise looks good

dlabrecq previously approved these changes Sep 25, 2019
View reviewed changes

dlabrecq left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM -- please fix tests

fix(Cards): refactor sub-component references
465cac2 
Due to patternfly#2931, rearrange the way `Card`
includes the component's sub-components to match the way the
`Wizard` (and all other components) does it.  The new style will
allow the subcomponent references to survive webpack tree shaking.
sjd78 dismissed stale reviews from dlabrecq and jeff-phillips-18 via 465cac2 October 16, 2019 01:26
sjd78 force-pushed the pf3-card-tree-shaking branch from 0507ca0 to 465cac2 Compare October 16, 2019 01:26

codecov-io commented Oct 16, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2935 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2935      +/-   ##
==========================================
+ Coverage   68.94%   68.98%   +0.04%     
==========================================
  Files         858      858              
  Lines       23590    23612      +22     
  Branches     1887     1887              
==========================================
+ Hits        16263    16288      +25     
+ Misses       6367     6364       -3     
  Partials      960      960
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <100%> (+0.07%) ⬆️
#patternfly4 67.93% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...y-3/patternfly-react/src/components/Cards/index.js 100% <100%> (ø) ⬆️
...ly-3/patternfly-react/src/components/Cards/Card.js 89.33% <100%> (+28.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031b8f7...465cac2. Read the comment docs.

sjd78 requested a review from dlabrecq October 16, 2019 14:36
dlabrecq merged commit 17a51ff into patternfly:master Oct 16, 2019
sjd78 deleted the pf3-card-tree-shaking branch October 16, 2019 14:45

patternfly-build commented Oct 16, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • patternfly-react-extensions@3.0.1
  • patternfly-react@2.39.5
  • @patternfly/react-console@2.0.1

Thanks for your contribution! 🎉

sjd78 mentioned this pull request Oct 30, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jeff-phillips-18 jeff-phillips-18 approved these changes
kmcfaul Awaiting requested review from kmcfaul
+1 more reviewer
dlabrecq dlabrecq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

kmcfaul

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL