Missing key prop warning for ChartPie based components - #2943
Merged
tlabaj merged 1 commit intoSep 23, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2943.surge.sh |
Sorry, something went wrong.
dlabrecq
force-pushed
the
2938-missing-key-prop-warn
branch
4 times, most recently
from
7204a2f to
17eca05
Compare
September 17, 2019 14:10
dlabrecq
force-pushed
the
2938-missing-key-prop-warn
branch
11 times, most recently
from
ba451c9 to
95d520b
Compare
September 19, 2019 21:31
dlabrecq
force-pushed
the
2938-missing-key-prop-warn
branch
from
95d520b to
e0e42e0
Compare
September 19, 2019 21:48
AllenBW
approved these changes
Sep 23, 2019
AllenBW
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
<3
Sorry, something went wrong.
redallen
approved these changes
Sep 23, 2019
redallen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I like this refactor and doing away with let currentId = 0;.
Sorry, something went wrong.
kmcfaul
approved these changes
Sep 23, 2019
tlabaj
approved these changes
Sep 23, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help eliminate the "missing key prop" warning seem in the browser console.
Fixes #2938