FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(charts): update chart tutorial paths by dlabrecq · Pull Request #2962 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(charts): update chart tutorial paths - #2962

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
dlabrecq:2961-tutorial-update
Sep 19, 2019
ConversationCommits (1)ChecksFiles changed
Merged

chore(charts): update chart tutorial paths#2962
tlabaj merged 1 commit into
patternfly:masterfrom
dlabrecq:2961-tutorial-update

Conversation

dlabrecq commented Sep 19, 2019

Copy link
Copy Markdown
Member

Renamed the chart tutorials to be more readable. As a result, paths to the chart tutorials must be updated.

Fixes #2961

patternfly-build commented Sep 19, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2962.surge.sh

tlabaj approved these changes Sep 19, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jenny-s51 approved these changes Sep 19, 2019
View reviewed changes

jenny-s51 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It seems like the comment I added might need to be addressed outside the scope of this issue -- otherwise the paths look good 🙂

Comment thread packages/patternfly-4/react-charts/src/components/ChartDonut/examples/ChartDonut.md
a consistent user experience.

[Start course](https://katacoda.com/patternfly/courses/charts/module-donut)
[Start course](https://katacoda.com/patternfly/courses/charts/donut-chart)

jenny-s51 Sep 19, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

When I follow this link, the title for the course is "intro to donut utilization chart components" rather than "donut chart components", but I think it needs to be the latter

dlabrecq Sep 19, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah, that's a typo in the Katacoda tutorial. I'll have to fix that in another repo. Thanks!

dlabrecq Sep 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed in Katacoda

tlabaj merged commit 96cac5b into patternfly:master Sep 19, 2019

patternfly-build commented Sep 19, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@5.0.3

Thanks for your contribution! 🎉

dlabrecq deleted the 2961-tutorial-update branch September 25, 2019 14:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
jenny-s51 jenny-s51 approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

redallen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update chart tutorial paths

5 participants

Back | FazBrowse Home | New Git URL