FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Table): Added OUIA compatibility to Table component by quarckster · Pull Request #2964 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Table): Added OUIA compatibility to Table component - #2964

Merged
tlabaj merged 3 commits into
patternfly:masterfrom
quarckster:table_ouia
Oct 10, 2019
ConversationCommits (3)ChecksFiles changed
Merged

feat(Table): Added OUIA compatibility to Table component #2964
tlabaj merged 3 commits into
patternfly:masterfrom
quarckster:table_ouia

Conversation

quarckster commented Sep 19, 2019

Copy link
Copy Markdown
Contributor

Closes #2426

What: Added OUIA props to Table component

patternfly-build commented Sep 19, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2964.surge.sh

tlabaj requested a review from redallen September 20, 2019 11:56
tlabaj requested a review from priley86 September 20, 2019 11:56
redallen previously approved these changes Sep 20, 2019
View reviewed changes
nicolethoen previously approved these changes Sep 23, 2019
View reviewed changes
priley86 previously approved these changes Sep 25, 2019
View reviewed changes
dlabrecq previously approved these changes Sep 25, 2019
View reviewed changes
tlabaj reviewed Sep 26, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This one has some merge conflicts.

karelhala added the ouia label Oct 1, 2019

codecov-io commented Oct 9, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2964 into master will increase coverage by <.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #2964      +/-   ##
==========================================
+ Coverage   69.02%   69.02%   +<.01%     
==========================================
  Files         858      858              
  Lines       23432    23447      +15     
  Branches     1859     1863       +4     
==========================================
+ Hits        16174    16185      +11     
- Misses       6337     6339       +2     
- Partials      921      923       +2
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.1% <75%> (ø) ⬆️
Impacted Files Coverage Δ
...rnfly-4/react-table/src/components/Table/Table.tsx 91.25% <75%> (-2%) ⬇️
...-4/react-table/src/components/Table/RowWrapper.tsx 77.55% <75%> (-1.52%) ⬇️
...y-3/patternfly-react/src/components/Table/Table.js 95.71% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7313d...2e4eef5. Read the comment docs.

quarckster commented Oct 9, 2019

Copy link
Copy Markdown
Contributor Author

@redallen tests passed

tlabaj approved these changes Oct 10, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 2a17e77 into patternfly:master Oct 10, 2019
quarckster deleted the table_ouia branch October 10, 2019 15:37

patternfly-build commented Oct 10, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-inline-edit-extension@2.11.84
  • @patternfly/react-table@2.23.0

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nicolethoen nicolethoen left review comments
+4 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
priley86 priley86 left review comments
dlabrecq dlabrecq left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

redallen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PF4: make table components OUIA compatible

9 participants

Back | FazBrowse Home | New Git URL