FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(react-table): fix cell title warning by priley86 · Pull Request #2967 · patternfly/patternfly-react · GitHub

fix(react-table): fix cell title warning - #2967

Merged
redallen merged 1 commit into
patternfly:masterfrom
priley86:table-fragments
Sep 20, 2019
Merged

fix(react-table): fix cell title warning#2967
redallen merged 1 commit into
patternfly:masterfrom
priley86:table-fragments

Conversation

Copy link
Copy Markdown
Member

What:
fix the warning in #2941 - the title prop should allow JSX too.

Additional issues:

AllenBW left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

😍 😍 😍 😍 😍 😍 😍

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2967.surge.sh

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj added PF4 and removed bug 🐛 labels Sep 19, 2019
tlabaj self-assigned this Sep 19, 2019
redallen merged commit e7c39b7 into patternfly:master Sep 20, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-inline-edit-extension@2.11.50
  • @patternfly/react-table@2.21.1

Thanks for your contribution! 🎉

AllenBW added a commit to AllenBW/insights-advisor-frontend that referenced this pull request Sep 23, 2019
AllenBW added a commit to RedHatInsights/insights-advisor-frontend that referenced this pull request Sep 23, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Sep 23, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Sep 23, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Sep 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL