FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(modal): change the cancel button variant to link by boaz0 · Pull Request #2979 · patternfly/patternfly-react · GitHub

docs(modal): change the cancel button variant to link - #2979

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_2585
Sep 25, 2019
Merged

docs(modal): change the cancel button variant to link#2979
tlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_2585

Conversation

boaz0 commented Sep 20, 2019
edited
Loading

Copy link
Copy Markdown
Member

What:
closes #2585

Update Modal document to have cancel button as link.

@jschuler is that what you meant?

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2979.surge.sh

jenny-s51 self-assigned this Sep 20, 2019

jenny-s51 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, waiting for @jschuler to confirm

Copy link
Copy Markdown
Member

Looks great. Thanks @boaz0 !

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit b9c2068 into patternfly:master Sep 25, 2019
boaz0 deleted the closes_2585 branch April 24, 2020 06:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modal: Cancel button should be a LinkButton

5 participants


Back | FazBrowse Home | New Git URL