FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(HorizontalNavMenuItem): Fix onItemClick PropType. by martinpovolny · Pull Request #2984 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(HorizontalNavMenuItem): Fix onItemClick PropType. - #2984

Merged
dlabaj merged 1 commit into
patternfly:masterfrom
martinpovolny:HorizontalNavMenuItem_onItemClick_fix
Sep 24, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(HorizontalNavMenuItem): Fix onItemClick PropType.#2984
dlabaj merged 1 commit into
patternfly:masterfrom
martinpovolny:HorizontalNavMenuItem_onItemClick_fix

Conversation

martinpovolny commented Sep 23, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

HorizontalNavMenuItem 's onItemClick should be a function not an object.

It's getting passed as onClick to <a href ...> so it must be a bug.

Issue: #2994

Ping @rvsia, @karelhala

fix(HorizontalNavMenuItem): Fix onItemClick PropType.
0e73459 
HorizontalNavMenuItem 's onItemClick should be a function not an object.
karelhala approved these changes Sep 23, 2019
View reviewed changes

karelhala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch!

patternfly-build commented Sep 23, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2984.surge.sh

martinpovolny added a commit to martinpovolny/react-ui-components that referenced this pull request Sep 23, 2019
Toolbar: fix opening of multiple items in kebab list.
3a67873 
Fix according to @rvsia.
Requires patternfly/patternfly-react#2984
martinpovolny mentioned this pull request Sep 23, 2019
Merged
tlabaj previously requested changes Sep 23, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you please link associated issue. Thanks!

martinpovolny commented Sep 23, 2019

Copy link
Copy Markdown
Contributor Author

Can you please link associated issue. Thanks!

There's none.

Do we need 6 people and an issue to merge a trivial 1 line fix to Patternfly?

dlabaj commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

@martinpovolny We do need an issue for all bugs (https://github.com/patternfly/patternfly-react/blob/master/CONTRIBUTING.md#creating-issues-for-bugs). We only need 2 approvals to merge a PR.

martinpovolny mentioned this pull request Sep 24, 2019
Closed

martinpovolny commented Sep 24, 2019

Copy link
Copy Markdown
Contributor Author

@dlabaj : Thank you for the information. Updating counter to 7 ;-)

I have created the issue as you required: #2994

However I cannot follow the steps you pointed me to 100%. I cannot assing the label because I do not have the permisions.

Regards.

dlabaj dismissed tlabaj’s stale review September 24, 2019 09:37

change was made

dlabaj merged commit 90e1792 into patternfly:master Sep 24, 2019

patternfly-build commented Sep 24, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • patternfly-react-extensions@2.20.6
  • patternfly-react@2.39.1
  • @patternfly/react-console@1.12.10

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
nicolethoen nicolethoen approved these changes
kmcfaul kmcfaul approved these changes
+3 more reviewers
karelhala karelhala approved these changes
rvsia rvsia approved these changes
tlabaj tlabaj left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL