FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Flex): Added support for flex layout, tests, etc. by rebeccaalpert · Pull Request #2985 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Flex): Added support for flex layout, tests, etc. - #2985

Merged
tlabaj merged 2 commits into
patternfly:masterfrom
rebeccaalpert:flex-item
Sep 25, 2019
ConversationCommits (2)ChecksFiles changed
Merged

feat(Flex): Added support for flex layout, tests, etc.#2985
tlabaj merged 2 commits into
patternfly:masterfrom
rebeccaalpert:flex-item

Conversation

rebeccaalpert commented Sep 23, 2019

Copy link
Copy Markdown
Member

Added React support for Flex and FlexItem. Moved Nicole's DataToolbar breakpoint utility to main utils and added tests so I could reuse it for Flex.

Fixes #2860.

feat(Flex): Added support for flex layout, tests, etc.
a634301 
Added React support for Flex and FlexItem. Moved DataToolbar's breakpoint utility to main utils and added tests.

Fixes #2860.

patternfly-build commented Sep 23, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2985.surge.sh

nicolethoen previously approved these changes Sep 23, 2019
View reviewed changes

nicolethoen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks beautiful!

kmcfaul previously approved these changes Sep 23, 2019
View reviewed changes
tlabaj suggested changes Sep 23, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add a demo and integration tests for this please.

rebeccaalpert dismissed stale reviews from kmcfaul and nicolethoen via e970878 September 24, 2019 08:36

rebeccaalpert commented Sep 24, 2019

Copy link
Copy Markdown
Member Author

Added demo and integration test.

mattnolting approved these changes Sep 24, 2019
View reviewed changes

mattnolting left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's beautiful! 🎉

mcarrano approved these changes Sep 25, 2019
View reviewed changes

mcarrano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me

tlabaj approved these changes Sep 25, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit bc5af59 into patternfly:master Sep 25, 2019

patternfly-build commented Sep 25, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.108.0
  • @patternfly/react-docs@4.13.22
  • @patternfly/react-inline-edit-extension@2.11.58
  • demo-app-ts@3.5.0
  • @patternfly/react-integration@3.5.0
  • @patternfly/react-table@2.22.7
  • @patternfly/react-topology@2.8.54
  • @patternfly/react-virtualized-extension@1.2.44

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mattnolting mattnolting approved these changes
nicolethoen nicolethoen approved these changes
kmcfaul kmcfaul left review comments
+2 more reviewers
mcarrano mcarrano approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Demo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add .pf-l-flex__item wrapper to examples

7 participants

Back | FazBrowse Home | New Git URL