FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(dropdown): disabled button only applies disabled attribute by jessiehuff · Pull Request #2989 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(dropdown): disabled button only applies disabled attribute #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 2 commits into from
Sep 25, 2019
Conversation 3 Commits 2 Checks 0 Files changed
Merged

fix(dropdown): disabled button only applies disabled attribute #2989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24ee490
Disabled button only applies disabled attribute
jessiehuff Sep 23, 2019
8a6780c
Update snapshots
jessiehuff Sep 23, 2019
File filter

Filter by extension

Filter by extension .snap  (3) .tsx  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
        • Toggle.tsx
      • Table.test.tsx.snap
1 change: 0 additions & 1 deletion packages/patternfly-4/react-core/src/components/Dropdown/Toggle.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ export class Toggle extends React.Component<ToggleProps> {
isHovered && styles.modifiers.hover,
isActive && styles.modifiers.active,
isPlain && styles.modifiers.plain,
isDisabled && styles.modifiers.disabled,
isPrimary && styles.modifiers.primary,
className
)}
Expand Down
8 changes: 4 additions & 4 deletions ...patternfly-4/react-core/src/components/OptionsMenu/__snapshots__/OptionsMenu.test.js.snap
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1611,7 +1611,7 @@ exports[`optionsMenu isDisabled 1`] = `
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Options menu"
class="pf-c-options-menu__toggle pf-m-disabled"
class="pf-c-options-menu__toggle"
disabled=""
id="disabled-toggle"
type="button"
Expand Down Expand Up @@ -1661,7 +1661,7 @@ exports[`optionsMenu isDisabled 1`] = `
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Options menu"
class="pf-c-options-menu__toggle pf-m-disabled"
class="pf-c-options-menu__toggle"
disabled=""
id="disabled-toggle"
type="button"
Expand Down Expand Up @@ -1715,7 +1715,7 @@ exports[`optionsMenu isDisabled 1`] = `
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Options menu"
class="pf-c-options-menu__toggle pf-m-disabled"
class="pf-c-options-menu__toggle"
disabled=""
id="disabled-toggle"
type="button"
Expand Down Expand Up @@ -1747,7 +1747,7 @@ exports[`optionsMenu isDisabled 1`] = `
aria-expanded={false}
aria-haspopup="listbox"
aria-label="Options menu"
className="pf-c-options-menu__toggle pf-m-disabled"
className="pf-c-options-menu__toggle"
disabled={true}
id="disabled-toggle"
onClick={[Function]}
Expand Down
24 changes: 12 additions & 12 deletions .../patternfly-4/react-core/src/components/Pagination/__snapshots__/Pagination.test.tsx.snap
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -5375,7 +5375,7 @@ exports[`component render no items 1`] = `
<button
aria-expanded="false"
aria-label="Select"
class="pf-c-dropdown__toggle pf-m-disabled pf-c-options-menu__toggle-button"
class="pf-c-dropdown__toggle pf-c-options-menu__toggle-button"
disabled=""
id="pagination-options-menu-toggle"
type="button"
Expand Down Expand Up @@ -5446,7 +5446,7 @@ exports[`component render no items 1`] = `
<button
aria-expanded="false"
aria-label="Select"
class="pf-c-dropdown__toggle pf-m-disabled pf-c-options-menu__toggle-button"
class="pf-c-dropdown__toggle pf-c-options-menu__toggle-button"
disabled=""
id="pagination-options-menu-toggle"
type="button"
Expand Down Expand Up @@ -5517,7 +5517,7 @@ exports[`component render no items 1`] = `
<button
aria-expanded="false"
aria-label="Select"
class="pf-c-dropdown__toggle pf-m-disabled pf-c-options-menu__toggle-button"
class="pf-c-dropdown__toggle pf-c-options-menu__toggle-button"
disabled=""
id="pagination-options-menu-toggle"
type="button"
Expand Down Expand Up @@ -5566,7 +5566,7 @@ exports[`component render no items 1`] = `
<button
aria-expanded={false}
aria-label="Select"
className="pf-c-dropdown__toggle pf-m-disabled pf-c-options-menu__toggle-button"
className="pf-c-dropdown__toggle pf-c-options-menu__toggle-button"
disabled={true}
id="pagination-options-menu-toggle"
onClick={[Function]}
Expand Down Expand Up @@ -7247,7 +7247,7 @@ exports[`component render should render correctly disabled 1`] = `
<button
aria-expanded="false"
aria-label="Select"
class="pf-c-dropdown__toggle pf-m-disabled pf-c-options-menu__toggle-button"
class="pf-c-dropdown__toggle pf-c-options-menu__toggle-button"
disabled=""
id="pagination-options-menu-toggle"
type="button"
Expand Down Expand Up @@ -7318,7 +7318,7 @@ exports[`component render should render correctly disabled 1`] = `
<button
aria-expanded="false"
aria-label="Select"
class="pf-c-dropdown__toggle pf-m-disabled pf-c-options-menu__toggle-button"
class="pf-c-dropdown__toggle pf-c-options-menu__toggle-button"
disabled=""
id="pagination-options-menu-toggle"
type="button"
Expand Down Expand Up @@ -7389,7 +7389,7 @@ exports[`component render should render correctly disabled 1`] = `
<button
aria-expanded="false"
aria-label="Select"
class="pf-c-dropdown__toggle pf-m-disabled pf-c-options-menu__toggle-button"
class="pf-c-dropdown__toggle pf-c-options-menu__toggle-button"
disabled=""
id="pagination-options-menu-toggle"
type="button"
Expand Down Expand Up @@ -7438,7 +7438,7 @@ exports[`component render should render correctly disabled 1`] = `
<button
aria-expanded={false}
aria-label="Select"
className="pf-c-dropdown__toggle pf-m-disabled pf-c-options-menu__toggle-button"
className="pf-c-dropdown__toggle pf-c-options-menu__toggle-button"
disabled={true}
id="pagination-options-menu-toggle"
onClick={[Function]}
Expand Down Expand Up @@ -11005,7 +11005,7 @@ exports[`component render zero results 1`] = `
<button
aria-expanded="false"
aria-label="Select"
class="pf-c-dropdown__toggle pf-m-disabled pf-c-options-menu__toggle-button"
class="pf-c-dropdown__toggle pf-c-options-menu__toggle-button"
disabled=""
id="pagination-options-menu-toggle"
type="button"
Expand Down Expand Up @@ -11076,7 +11076,7 @@ exports[`component render zero results 1`] = `
<button
aria-expanded="false"
aria-label="Select"
class="pf-c-dropdown__toggle pf-m-disabled pf-c-options-menu__toggle-button"
class="pf-c-dropdown__toggle pf-c-options-menu__toggle-button"
disabled=""
id="pagination-options-menu-toggle"
type="button"
Expand Down Expand Up @@ -11147,7 +11147,7 @@ exports[`component render zero results 1`] = `
<button
aria-expanded="false"
aria-label="Select"
class="pf-c-dropdown__toggle pf-m-disabled pf-c-options-menu__toggle-button"
class="pf-c-dropdown__toggle pf-c-options-menu__toggle-button"
disabled=""
id="pagination-options-menu-toggle"
type="button"
Expand Down Expand Up @@ -11196,7 +11196,7 @@ exports[`component render zero results 1`] = `
<button
aria-expanded={false}
aria-label="Select"
className="pf-c-dropdown__toggle pf-m-disabled pf-c-options-menu__toggle-button"
className="pf-c-dropdown__toggle pf-c-options-menu__toggle-button"
disabled={true}
id="pagination-options-menu-toggle"
onClick={[Function]}
Expand Down
6 changes: 3 additions & 3 deletions packages/patternfly-4/react-table/src/components/Table/__snapshots__/Table.test.tsx.snap
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -67053,7 +67053,7 @@ exports[`Simple Actions table 1`] = `
aria-expanded="false"
aria-haspopup="true"
aria-label="Actions"
class="pf-c-dropdown__toggle pf-m-plain pf-m-disabled"
class="pf-c-dropdown__toggle pf-m-plain"
disabled=""
id="pf-toggle-id-9"
type="button"
Expand Down Expand Up @@ -67101,7 +67101,7 @@ exports[`Simple Actions table 1`] = `
aria-expanded="false"
aria-haspopup="true"
aria-label="Actions"
class="pf-c-dropdown__toggle pf-m-plain pf-m-disabled"
class="pf-c-dropdown__toggle pf-m-plain"
disabled=""
id="pf-toggle-id-9"
type="button"
Expand Down Expand Up @@ -67129,7 +67129,7 @@ exports[`Simple Actions table 1`] = `
aria-expanded={false}
aria-haspopup={true}
aria-label="Actions"
className="pf-c-dropdown__toggle pf-m-plain pf-m-disabled"
className="pf-c-dropdown__toggle pf-m-plain"
disabled={true}
id="pf-toggle-id-9"
onClick={[Function]}
Expand Down
Back | FazBrowse Home | New Git URL