| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
This was a problem with the defaultProps' type, I pushed a change that will hopefully fix it. |
Sorry, something went wrong.
|
PatternFly-React preview: https://patternfly-react-pr-2996.surge.sh |
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #2996 +/- ##
==========================================
- Coverage 69.02% 68.98% -0.05%
==========================================
Files 858 858
Lines 23432 23450 +18
Branches 1859 1862 +3
==========================================
+ Hits 16174 16177 +3
- Misses 6337 6351 +14
- Partials 921 922 +1
Continue to review full report at Codecov.
|
Sorry, something went wrong.
|
Fixed the type used in a test. |
Sorry, something went wrong.
|
@redallen I'm afraid I can't fix failed tests. These errors are so cryptic to me. |
Sorry, something went wrong.
|
@quarckster you gotta update snapshots in order to fix circle build, this can be done by running |
Sorry, something went wrong.
|
@karelhala I applied your patch but there are still some errors |
Sorry, something went wrong.
|
If you rebase on latest upstream and run yarn test:pf4 -u I think it should work. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
What: Added OUIA props to Tabs as per #2423
Additional issues: tests failed:
FAIL packages/patternfly-4/react-core/src/components/Select/Select.test.tsx ● Test suite failed to run TypeScript diagnostics (customize using `[jest-config].globals.ts-jest.diagnostics` option): packages/patternfly-4/react-core/src/components/Select/Select.tsx:538:47 - error TS2345: Argument of type 'typeof Select' is not assignable to parameter of type 'ComponentClass<SelectProps & InjectedOuiaProps, any> | FunctionComponent<SelectProps & InjectedOuiaProps>'. Type 'typeof Select' is not assignable to type 'ComponentClass<SelectProps & InjectedOuiaProps, any>'. Types of property 'defaultProps' are incompatible. Type '{ "children": ReactElement<any, string | ((props: any) => ReactElement<any, string | ... | (new (props: any) => Component<any, any, any>)>) | (new (props: any) => Component<any, any, any>)>[]; ... 21 more ...; "onFilter": () => {}; }' is not assignable to type 'Partial<SelectProps & InjectedOuiaProps>'. Types of property 'onClear' are incompatible. Type 'Function' is not assignable to type '(event: MouseEvent<Element, MouseEvent>) => void'. Type 'Function' provides no match for the signature '(event: MouseEvent<Element, MouseEvent>): void'. 538 const SelectWithOuiaContext = withOuiaContext(Select);@redallen @jschuler @karelhala I would appreciate any help with this.