FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added OUIA compatibility to Select component by quarckster · Pull Request #2996 · patternfly/patternfly-react · GitHub

Added OUIA compatibility to Select component - #2996

Merged
redallen merged 3 commits into
patternfly:masterfrom
quarckster:select_ouia
Oct 11, 2019
Merged

Added OUIA compatibility to Select component#2996
redallen merged 3 commits into
patternfly:masterfrom
quarckster:select_ouia

Conversation

Copy link
Copy Markdown
Contributor

What: Added OUIA props to Tabs as per #2423

Additional issues: tests failed:

 FAIL  packages/patternfly-4/react-core/src/components/Select/Select.test.tsx
  ● Test suite failed to run

    TypeScript diagnostics (customize using `[jest-config].globals.ts-jest.diagnostics` option):
    packages/patternfly-4/react-core/src/components/Select/Select.tsx:538:47 - error TS2345: Argument of type 'typeof Select' is not assignable to parameter of type 'ComponentClass<SelectProps & InjectedOuiaProps, any> | FunctionComponent<SelectProps & InjectedOuiaProps>'.
      Type 'typeof Select' is not assignable to type 'ComponentClass<SelectProps & InjectedOuiaProps, any>'.
        Types of property 'defaultProps' are incompatible.
          Type '{ "children": ReactElement<any, string | ((props: any) => ReactElement<any, string | ... | (new (props: any) => Component<any, any, any>)>) | (new (props: any) => Component<any, any, any>)>[]; ... 21 more ...; "onFilter": () => {}; }' is not assignable to type 'Partial<SelectProps & InjectedOuiaProps>'.
            Types of property 'onClear' are incompatible.
              Type 'Function' is not assignable to type '(event: MouseEvent<Element, MouseEvent>) => void'.
                Type 'Function' provides no match for the signature '(event: MouseEvent<Element, MouseEvent>): void'.

    538 const SelectWithOuiaContext = withOuiaContext(Select);

@redallen @jschuler @karelhala I would appreciate any help with this.

redallen force-pushed the select_ouia branch 2 times, most recently from b60624e to a656bd0 Compare September 25, 2019 15:08

Copy link
Copy Markdown
Contributor

This was a problem with the defaultProps' type, I pushed a change that will hopefully fix it.

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2996.surge.sh

codecov-io commented Sep 25, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2996 into master will decrease coverage by 0.04%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##           master    #2996      +/-   ##
==========================================
- Coverage   69.02%   68.98%   -0.05%     
==========================================
  Files         858      858              
  Lines       23432    23450      +18     
  Branches     1859     1862       +3     
==========================================
+ Hits        16174    16177       +3     
- Misses       6337     6351      +14     
- Partials      921      922       +1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (-0.01%) ⬇️
#patternfly4 68% <69.23%> (-0.1%) ⬇️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Select/Select.tsx 60.93% <69.23%> (-2.4%) ⬇️
...ternfly-3/react-console/src/SerialConsole/XTerm.js 25% <0%> (-2.42%) ⬇️
...y-react-extensions/src/components/Select/Select.js 19.8% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7313d...7c4d27e. Read the comment docs.

Copy link
Copy Markdown
Contributor

Fixed the type used in a test.

Copy link
Copy Markdown
Contributor Author

@redallen I'm afraid I can't fix failed tests. These errors are so cryptic to me.

karelhala requested review from kmcfaul, redallen and tlabaj and removed request for kmcfaul October 1, 2019 11:24
karelhala added the ouia label Oct 1, 2019
karelhala previously approved these changes Oct 1, 2019

Copy link
Copy Markdown
Contributor

@quarckster you gotta update snapshots in order to fix circle build, this can be done by running
node_modules/.bin/jest -u packages/patternfly-4/react-core/src/components/Select

quarckster commented Oct 8, 2019
edited
Loading

Copy link
Copy Markdown
Contributor Author

@karelhala I applied your patch but there are still some errors

redallen commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

If you rebase on latest upstream and run yarn test:pf4 -u I think it should work.

Copy link
Copy Markdown
Contributor Author

@redallen tests passed

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

redallen merged commit 4920cf1 into patternfly:master Oct 11, 2019
quarckster deleted the select_ouia branch October 11, 2019 13:13

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.114.1
  • @patternfly/react-docs@4.14.17
  • @patternfly/react-inline-edit-extension@2.11.86
  • demo-app-ts@3.7.1
  • @patternfly/react-table@2.23.2
  • @patternfly/react-topology@2.8.79
  • @patternfly/react-virtualized-extension@1.2.69

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL