fix(react-table): Disable header controls with empty table - #3008
Merged
tlabaj merged 1 commit intoOct 15, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-3008.surge.sh |
Sorry, something went wrong.
dlabrecq
previously approved these changes
Sep 25, 2019
When no rows exist in the table, disable the select all checkbox if present, and disable the sortable column mouse behavior (mouse pointer, text highlight) patternfly#1431
jcaianirh
force-pushed
the
pf4table-header-controls
branch
from
7aaccdd to
ffc2268
Compare
October 11, 2019 19:59
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #3008 +/- ##
==========================================
+ Coverage 69.02% 69.03% +<.01%
==========================================
Files 858 858
Lines 23535 23539 +4
Branches 1877 1879 +2
==========================================
+ Hits 16246 16250 +4
Misses 6336 6336
Partials 953 953
Continue to review full report at Codecov.
|
Sorry, something went wrong.
tlabaj
previously approved these changes
Oct 11, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
dlabaj
approved these changes
Oct 11, 2019
dlabrecq
approved these changes
Oct 15, 2019
tlabaj
approved these changes
Oct 15, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1431
What: When no rows exist in the table, disable the select all checkbox if present, and disable the sortable column mouse behavior (mouse pointer, text highlight)
Additional issues: