FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(DataToolbar): add aria-haspopup to the toggle group by tlabaj · Pull Request #3012 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(DataToolbar): add aria-haspopup to the toggle group #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redallen merged 1 commit into from
Sep 26, 2019
Conversation 1 Commits 1 Checks 0 Files changed
Merged

fix(DataToolbar): add aria-haspopup to the toggle group #3012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .tsx  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
9 changes: 8 additions & 1 deletion ...atternfly-4/react-core/src/experimental/components/DataToolbar/DataToolbarToggleGroup.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { css, getModifier } from '@patternfly/react-styles';
import { DataToolbarGroupProps } from './DataToolbarGroup';
import { DataToolbarContext } from './DataToolbarUtils';
import { Button } from '../../../components/Button';
import { global_breakpoint_lg as globalBreakpointLg } from '@patternfly/react-tokens';

import {
DataToolbarBreakpointMod,
Expand All @@ -27,6 +28,12 @@ export class DataToolbarToggleGroup extends React.Component<DataToolbarToggleGro
spacers: [] as DataToolbarSpacer[],
};

isContentPopup = () => {
const viewportSize = window.innerWidth;
const lgBreakpointValue = parseInt(globalBreakpointLg.value);
return viewportSize < lgBreakpointValue;
}

render() {
const { toggleIcon, breakpoint, variant, breakpointMods, spacers, className, children, ...props } = this.props;

Expand All @@ -50,7 +57,7 @@ export class DataToolbarToggleGroup extends React.Component<DataToolbarToggleGro
variant="plain"
onClick={toggleIsExpanded}
{...isExpanded && { 'aria-expanded': true }}
// TODO aria-haspopup when isExpanded = true && viewport is smaller than lg global breakpoint
aria-haspopup={isExpanded && this.isContentPopup()}
aria-controls={expandableContentId}
>
{toggleIcon}
Expand Down
Back | FazBrowse Home | New Git URL