FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

SerialConsole: Use xterm v4 by marusak · Pull Request #3030 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

SerialConsole: Use xterm v4 - #3030

Merged
jeff-phillips-18 merged 2 commits into
patternfly:masterfrom
marusak:xterm400
Oct 8, 2019
ConversationCommits (2)ChecksFiles changed
Merged

SerialConsole: Use xterm v4#3030
jeff-phillips-18 merged 2 commits into
patternfly:masterfrom
marusak:xterm400

Conversation

marusak commented Sep 27, 2019

Copy link
Copy Markdown
Contributor

What: Use xterm v4 in SerialConsole. Fixes #2912

marusak mentioned this pull request Sep 27, 2019
Closed
1 task

patternfly-build commented Sep 27, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3030.surge.sh

codecov-io commented Sep 27, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3030 into master will decrease coverage by 0.03%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #3030      +/-   ##
==========================================
- Coverage   68.98%   68.94%   -0.04%     
==========================================
  Files         857      852       -5     
  Lines       23421    23284     -137     
  Branches     1819     1790      -29     
==========================================
- Hits        16156    16053     -103     
+ Misses       6365     6343      -22     
+ Partials      900      888      -12
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.17% <50%> (ø) ⬆️
#patternfly4 67.99% <ø> (-0.1%) ⬇️
Impacted Files Coverage Δ
...ternfly-3/react-console/src/SerialConsole/XTerm.js 27.86% <50%> (+2.44%) ⬆️
...ct-core/src/components/Dropdown/DropdownToggle.tsx 84.84% <0%> (-3.04%) ⬇️
...eact-core/src/components/Dropdown/DropdownItem.tsx 70.58% <0%> (-1.64%) ⬇️
...rnfly-3/patternfly-react/src/components/Nav/Nav.js 43.24% <0%> (-0.35%) ⬇️
...eact-core/src/components/Pagination/Navigation.tsx 87.95% <0%> (-0.15%) ⬇️
...nfly-react/src/components/Pagination/Pagination.js 27.83% <0%> (ø) ⬆️
...rc/components/Pagination/PaginationOptionsMenu.tsx 93.54% <0%> (ø) ⬆️
...nfly-4/react-core/src/components/Dropdown/index.ts 100% <0%> (ø) ⬆️
...eact-core/src/components/Pagination/Pagination.tsx 82.53% <0%> (ø) ⬆️
...rnfly-4/react-table/src/components/Table/Table.tsx 93.24% <0%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1bd56f...3d1b2c7. Read the comment docs.

marusak commented Oct 2, 2019

Copy link
Copy Markdown
Contributor Author

Can I get a review on this? (not really sure who to ping, maybe @mareklibra as he has some commits in serial console)

tlabaj added PF3 labels Oct 2, 2019

jeff-phillips-18 commented Oct 2, 2019

Copy link
Copy Markdown
Member

code changes look ok to me but I don't really know this package all that well. If @mareklibra is OK with it then I am.

tlabaj self-assigned this Oct 3, 2019
dlabrecq reviewed Oct 4, 2019
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this a breaking change? That is, considering users must now move to xterm-4.0.0, change their imports, etc.?

marusak commented Oct 4, 2019

Copy link
Copy Markdown
Contributor Author

yes, users needs to move xterm to 4.0.0. But otherwise there should be no other visible change nor they do not need to adjust their code in any way.

marusak mentioned this pull request Oct 4, 2019
Closed

dlabrecq commented Oct 4, 2019

Copy link
Copy Markdown
Member

As long as it's not considered a breaking change, I believe it would be ok.

martinpitt commented Oct 8, 2019

Copy link
Copy Markdown

Sorry for nagging, but is there anything else to be done on our (@marusak 's) side? This seems approved and all tests passed. Thanks!

jeff-phillips-18 commented Oct 8, 2019

Copy link
Copy Markdown
Member

Should this be a breaking change? Regardless, the commit message needs to be updated for semantic release. If breaking, then please use major otherwise feat would do.

marusak commented Oct 8, 2019

Copy link
Copy Markdown
Contributor Author

Should this be a breaking change?

I answered this in a previous comment

Regardless, the commit message needs to be updated for semantic release. If breaking, then please use major otherwise feat would do.

Can this be done on squashing? If it can, then I don't need to push force and then tests don't need to re-run. Otherwise I can edit the commit message (feat(SerialConsole): Use xterm v4 would work, I guess?)

jeff-phillips-18 commented Oct 8, 2019

Copy link
Copy Markdown
Member

Sorry, I guess my question is, if adopters are forced to move to xterm 4.0.0 then wouldn't this be a breaking change?

marusak commented Oct 8, 2019

Copy link
Copy Markdown
Contributor Author

Sorry, I guess my question is, if adopters are forced to move to xterm 4.0.0 then wouldn't this be a breaking change?

I don't know what is defined as breaking change. It requires users to update xterm to 4.0.0, but otherwise they should not notice any difference and they do not need to update their code (unless they use xterm on other places as well).

jeff-phillips-18 commented Oct 8, 2019

Copy link
Copy Markdown
Member

I'm going to flag this for a major release as it would break consumers if they pull this change and do nothing else.

jeff-phillips-18 added Breaking change 💥 this change requires a major release and has API changes. and removed enhancement 🚀 labels Oct 8, 2019
refactor(react-console): use xterm@^4.0.0
3d1b2c7 
BREAKING CHANGE: bump xterm from ^3.3.0 to ^4.0.0
redallen approved these changes Oct 8, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I added an empty commit with a proper message for a major release for @patternfly/react-console.

jeff-phillips-18 merged commit 383ec51 into patternfly:master Oct 8, 2019

patternfly-build commented Oct 8, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • patternfly-react-extensions@3.0.0
  • @patternfly/react-console@2.0.0
  • @patternfly/react-core@3.113.2
  • @patternfly/react-docs@4.14.13
  • @patternfly/react-inline-edit-extension@2.11.81
  • demo-app-ts@3.6.20
  • @patternfly/react-table@2.22.30
  • @patternfly/react-topology@2.8.75
  • @patternfly/react-virtualized-extension@1.2.65

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jeff-phillips-18 jeff-phillips-18 approved these changes
mareklibra Awaiting requested review from mareklibra
+2 more reviewers
dlabrecq dlabrecq approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

tlabaj

Labels

Breaking change 💥 this change requires a major release and has API changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to xterm v4 in console

8 participants

Back | FazBrowse Home | New Git URL