FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor(Tabs): move TabButton to new file by tlabaj · Pull Request #3033 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

refactor(Tabs): move TabButton to new file - #3033

Merged
redallen merged 3 commits into
patternfly:masterfrom
tlabaj:tabsRefactor
Oct 3, 2019
ConversationCommits (3)ChecksFiles changed
Merged

refactor(Tabs): move TabButton to new file#3033
redallen merged 3 commits into
patternfly:masterfrom
tlabaj:tabsRefactor

Conversation

tlabaj commented Sep 27, 2019

Copy link
Copy Markdown
Contributor

…rate component

#3032

What:

Additional issues:

codecov-io commented Sep 27, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3033 into master will increase coverage by 0.04%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master    #3033      +/-   ##
==========================================
+ Coverage   68.97%   69.01%   +0.04%     
==========================================
  Files         857      858       +1     
  Lines       23445    23402      -43     
  Branches     1847     1848       +1     
==========================================
- Hits        16171    16151      -20     
+ Misses       6357     6333      -24     
- Partials      917      918       +1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (ø) ⬆️
#patternfly4 68.07% <94.44%> (+0.07%) ⬆️
Impacted Files Coverage Δ
...atternfly-4/react-core/src/components/Tabs/Tab.tsx 66.66% <100%> (-28.08%) ⬇️
...tternfly-4/react-core/src/components/Tabs/Tabs.tsx 69.35% <100%> (ø) ⬆️
...fly-4/react-core/src/components/Tabs/TabButton.tsx 93.75% <93.75%> (ø)
...fly-3/patternfly-react/src/components/Tabs/Tabs.js 32.87% <0%> (ø) ⬆️
...nfly-3/patternfly-react/src/components/Tabs/Tab.js 88.88% <0%> (+36.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c862f...bbfc245. Read the comment docs.

patternfly-build commented Sep 27, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3033.surge.sh

dlabrecq previously approved these changes Sep 30, 2019
View reviewed changes

dlabrecq left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I built and tested the tab changes in Cost Management. I didn't encounter any issues and no warning messages in the browser console

redallen commented Sep 30, 2019

Copy link
Copy Markdown
Contributor

There's a merge conflict now.

redallen changed the title refactor(Tabs): Refactor Tabs so the Tab Button is rendered in a sepa… refactor(Tabs): move TabButton to new file Oct 3, 2019
redallen approved these changes Oct 3, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good refactor, this is what I should have written during the TS conversion. Props for the docs look good too.

redallen merged commit 74ab953 into patternfly:master Oct 3, 2019
tlabaj mentioned this pull request Oct 4, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj Awaiting requested review from dlabaj
rebeccaalpert Awaiting requested review from rebeccaalpert
jessiehuff Awaiting requested review from jessiehuff
2 more reviewers
dlabrecq dlabrecq approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jessiehuff

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL