FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(button): add an example of a link button with anchor by boaz0 · Pull Request #3034 · patternfly/patternfly-react · GitHub

docs(button): add an example of a link button with anchor - #3034

Merged
dlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_3020
Oct 11, 2019
Merged

docs(button): add an example of a link button with anchor#3034
dlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_3020

Conversation

boaz0 commented Sep 28, 2019

Copy link
Copy Markdown
Member

What:

closes #3020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3034.surge.sh

codecov-io commented Sep 28, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3034 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3034      +/-   ##
==========================================
- Coverage   69.03%   68.98%   -0.05%     
==========================================
  Files         859      857       -2     
  Lines       23439    23421      -18     
  Branches     1859     1819      -40     
==========================================
- Hits        16180    16156      -24     
- Misses       6337     6365      +28     
+ Partials      922      900      -22
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.16% <ø> (-0.07%) ⬇️
#patternfly4 68.09% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
...nfly-3/patternfly-react/src/components/Tabs/Tab.js 51.92% <0%> (-36.97%) ⬇️
...table/src/components/Table/base/resolve-row-key.ts 40% <0%> (-13.85%) ⬇️
...ore/src/components/Select/CheckboxSelectOption.tsx 52.94% <0%> (-11.51%) ⬇️
...t-charts/src/components/ChartUtils/chart-origin.ts 20% <0%> (-8.58%) ⬇️
.../patternfly-3/patternfly-react/src/common/Timer.js 51.61% <0%> (-5.97%) ⬇️
...patternfly-4/react-core/src/components/Nav/Nav.tsx 71.42% <0%> (-5.17%) ⬇️
...-react/src/components/DateTimePicker/TimePicker.js 59.18% <0%> (-4.65%) ⬇️
...react/src/components/DateTimePicker/TimeHelpers.js 63.63% <0%> (-4.55%) ⬇️
...re/src/components/EmptyState/EmptyStatePrimary.tsx 83.33% <0%> (-4.17%) ⬇️
...ernfly-4/react-core/src/components/Badge/Badge.tsx 66.66% <0%> (-3.34%) ⬇️
... and 164 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b1e53c...bc8e571. Read the comment docs.

dlabrecq previously approved these changes Oct 7, 2019
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
dlabaj merged commit 48e2818 into patternfly:master Oct 11, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.114.2
  • @patternfly/react-docs@4.14.18
  • @patternfly/react-inline-edit-extension@2.11.87
  • demo-app-ts@3.7.2
  • @patternfly/react-table@2.23.3
  • @patternfly/react-topology@2.8.80
  • @patternfly/react-virtualized-extension@1.2.70

Thanks for your contribution! 🎉

boaz0 deleted the closes_3020 branch October 12, 2019 17:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button: Add an example of a link button with anchor component

6 participants


Back | FazBrowse Home | New Git URL