FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(switch): revert defaultChecked to checked by redallen · Pull Request #3037 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(switch): revert defaultChecked to checked - #3037

Merged
dlabaj merged 1 commit into
patternfly:masterfrom
redallen:chore/switch-revert
Oct 15, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(switch): revert defaultChecked to checked#3037
dlabaj merged 1 commit into
patternfly:masterfrom
redallen:chore/switch-revert

Conversation

redallen commented Sep 30, 2019

Copy link
Copy Markdown
Contributor

What: Closes #2997, reverts #2749

Additional issues:

patternfly-build commented Sep 30, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3037.surge.sh

dlabrecq previously approved these changes Oct 4, 2019
View reviewed changes
tlabaj previously approved these changes Oct 8, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

redallen dismissed stale reviews from tlabaj and dlabrecq via d93e819 October 11, 2019 15:01
redallen force-pushed the chore/switch-revert branch from 175bc40 to d93e819 Compare October 11, 2019 15:01

codecov-io commented Oct 11, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3037 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3037   +/-   ##
=======================================
  Coverage   69.03%   69.03%           
=======================================
  Files         858      858           
  Lines       23529    23529           
  Branches     1875     1875           
=======================================
  Hits        16244    16244           
  Misses       6334     6334           
  Partials      951      951
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.13% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Switch/Switch.tsx 66.66% <ø> (ø) ⬆️
...ore/src/components/Select/CheckboxSelectOption.tsx 64.44% <100%> (ø) ⬆️
.../react-core/src/components/Select/SelectOption.tsx 71.87% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedb42b...d93e819. Read the comment docs.

tlabaj approved these changes Oct 11, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj merged commit 329146c into patternfly:master Oct 15, 2019

patternfly-build commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.116.1
  • @patternfly/react-docs@4.14.27
  • @patternfly/react-inline-edit-extension@2.11.95
  • demo-app-ts@3.7.10
  • @patternfly/react-table@2.23.11
  • @patternfly/react-topology@2.9.5
  • @patternfly/react-virtualized-extension@1.2.78

Thanks for your contribution! 🎉

kmcfaul mentioned this pull request Jan 16, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+2 more reviewers
tlabaj tlabaj approved these changes
dlabrecq dlabrecq left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

kmcfaul

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Revert changing checked attribute for Switch

7 participants

Back | FazBrowse Home | New Git URL