FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(table): Adds support for custom dataLabel prop on table header by AllenBW · Pull Request #3040 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(table): Adds support for custom dataLabel prop on table header - #3040

Merged
redallen merged 1 commit into
patternfly:masterfrom
AllenBW:enhancement/fix-table-collapse-data-label
Oct 3, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(table): Adds support for custom dataLabel prop on table header#3040
redallen merged 1 commit into
patternfly:masterfrom
AllenBW:enhancement/fix-table-collapse-data-label

Conversation

AllenBW commented Sep 30, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #2941

but just in case you don't want to read the issue.... tl;dr: when collapsed table shows a very undesired column-foo when jsx is used as the table header. So lets allow for a custom data-label attribute to be passed when a dev wants to do this, so they can avoid the erum, undesired collapsed header

just in case yah wanta see what we're attempting to fix... (top is collapsed, bottom is expanded)

patternfly-build commented Sep 30, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3040.surge.sh

codecov-io commented Sep 30, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3040 into master will increase coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #3040      +/-   ##
==========================================
+ Coverage   68.97%   68.97%   +<.01%     
==========================================
  Files         857      857              
  Lines       23445    23422      -23     
  Branches     1847     1820      -27     
==========================================
- Hits        16171    16156      -15     
- Misses       6357     6365       +8     
+ Partials      917      901      -16
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.16% <ø> (-0.06%) ⬇️
#patternfly4 68.08% <50%> (+0.08%) ⬆️
Impacted Files Coverage Δ
...rnfly-4/react-table/src/components/Table/Table.tsx 93.24% <ø> (ø) ⬆️
...-4/react-table/src/components/Table/HeaderCell.tsx 73.33% <0%> (-5.24%) ⬇️
...t-table/src/components/Table/utils/headerUtils.tsx 96.29% <100%> (-0.58%) ⬇️
...table/src/components/Table/base/resolve-row-key.ts 40% <0%> (-13.85%) ⬇️
...ore/src/components/Select/CheckboxSelectOption.tsx 52.94% <0%> (-11.51%) ⬇️
...t-charts/src/components/ChartUtils/chart-origin.ts 20% <0%> (-8.58%) ⬇️
.../patternfly-3/patternfly-react/src/common/Timer.js 51.61% <0%> (-5.97%) ⬇️
...patternfly-4/react-core/src/components/Nav/Nav.tsx 71.42% <0%> (-5.17%) ⬇️
...-react/src/components/DateTimePicker/TimePicker.js 59.18% <0%> (-4.65%) ⬇️
...react/src/components/DateTimePicker/TimeHelpers.js 63.63% <0%> (-4.55%) ⬇️
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d7a7f...517ef53. Read the comment docs.

AllenBW mentioned this pull request Sep 30, 2019
Merged
AllenBW force-pushed the enhancement/fix-table-collapse-data-label branch from 119d1ff to 517ef53 Compare October 2, 2019 14:39
AllenBW requested a review from redallen October 2, 2019 14:48

AllenBW commented Oct 2, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@redallen any chance this pr can get another review from yah? we (insights app) would like to try n get this in (and use it) before this friday if possible

tlabaj approved these changes Oct 3, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

tm

redallen approved these changes Oct 3, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@AllenBW I'd say there's a chance.

redallen merged commit 79a8249 into patternfly:master Oct 3, 2019

patternfly-build commented Oct 3, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-inline-edit-extension@2.11.73
  • @patternfly/react-table@2.22.22

Thanks for your contribution! 🎉

AllenBW deleted the enhancement/fix-table-collapse-data-label branch October 3, 2019 12:58

AllenBW commented Oct 3, 2019

Copy link
Copy Markdown
Contributor Author

@redallen @tlabaj ya'll rocked my thursday, thank you 🙇‍♀

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PF4 react-table colums (title) to support jsx (also in collapsed view)

5 participants

Back | FazBrowse Home | New Git URL