FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Charts: Cannot wrap chart with Tippy tooltip by dlabrecq · Pull Request #3048 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Charts: Cannot wrap chart with Tippy tooltip - #3048

Merged
redallen merged 1 commit into
patternfly:masterfrom
dlabrecq:3047-chart-containers
Oct 1, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Charts: Cannot wrap chart with Tippy tooltip#3048
redallen merged 1 commit into
patternfly:masterfrom
dlabrecq:3047-chart-containers

Conversation

dlabrecq commented Oct 1, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Slightly modified how chart containers are cloned and added examples. This ensures charts can be wrapped with the Tippy tooltip component as an alternate way of providing custom tooltips.

Fixes #3047

patternfly-build commented Oct 1, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3048.surge.sh

codecov-io commented Oct 1, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3048 into master will decrease coverage by 0.04%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master    #3048      +/-   ##
==========================================
- Coverage   68.98%   68.93%   -0.05%     
==========================================
  Files         857      857              
  Lines       23421    23437      +16     
  Branches     1819     1835      +16     
==========================================
  Hits        16156    16156              
  Misses       6365     6365              
- Partials      900      916      +16
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.16% <ø> (ø) ⬆️
#patternfly4 67.98% <20%> (-0.11%) ⬇️
Impacted Files Coverage Δ
...ChartBullet/ChartBulletComparativeErrorMeasure.tsx 74.19% <0%> (-2.48%) ⬇️
...nents/ChartBullet/ChartBulletPrimaryDotMeasure.tsx 65.85% <0%> (-3.38%) ⬇️
...onents/ChartBullet/ChartBulletQualitativeRange.tsx 56.25% <0%> (-2.45%) ⬇️
...artBullet/ChartBulletComparativeWarningMeasure.tsx 74.19% <0%> (-2.48%) ⬇️
...ChartBullet/ChartBulletPrimarySegmentedMeasure.tsx 55.1% <0%> (-2.35%) ⬇️
...-charts/src/components/ChartBullet/ChartBullet.tsx 60% <0%> (-2.59%) ⬇️
...ents/ChartBullet/ChartBulletComparativeMeasure.tsx 58.69% <0%> (-2.67%) ⬇️
...ts/ChartDonutUtilization/ChartDonutUtilization.tsx 73.49% <50%> (ø) ⬆️
...ents/ChartDonutUtilization/ChartDonutThreshold.tsx 72.72% <50%> (ø) ⬆️
.../react-charts/src/components/ChartPie/ChartPie.tsx 75.47% <50%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 259fc78...7ab0e46. Read the comment docs.

jeff-phillips-18 approved these changes Oct 1, 2019
View reviewed changes

jeff-phillips-18 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks Dan!

redallen merged commit 68f4311 into patternfly:master Oct 1, 2019

patternfly-build commented Oct 1, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@5.0.13

Thanks for your contribution! 🎉

tlabaj mentioned this pull request Dec 17, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jeff-phillips-18 jeff-phillips-18 approved these changes
+1 more reviewer
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Charts: Cannot wrap chart with Tippy tooltip

5 participants

Back | FazBrowse Home | New Git URL