FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fixed sentence case for component titles by janwright73 · Pull Request #3054 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fixed sentence case for component titles - #3054

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
janwright73:fix/sentencecase
Oct 2, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fixed sentence case for component titles#3054
tlabaj merged 1 commit into
patternfly:masterfrom
janwright73:fix/sentencecase

Conversation

janwright73 commented Oct 1, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

What:
fixes React items in patternfly/patternfly-org#1486; Zack is working on refactoring the HTML items in same issue.

Additional issues:
Opened React issue to track this PR: #3062

patternfly-build commented Oct 1, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3054.surge.sh

codecov-io commented Oct 1, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3054 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3054   +/-   ##
=======================================
  Coverage   68.93%   68.93%           
=======================================
  Files         857      857           
  Lines       23437    23437           
  Branches     1835     1835           
=======================================
  Hits        16156    16156           
  Misses       6365     6365           
  Partials      916      916
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.16% <ø> (ø) ⬆️
#patternfly4 67.98% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d11315...9447427. Read the comment docs.

tlabaj suggested changes Oct 2, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you please link an associated react repo issue. Let me know if you would like me to open it for you.

janwright73 commented Oct 2, 2019

Copy link
Copy Markdown
Contributor Author

Hi @tlabaj - opened #3062

tlabaj approved these changes Oct 2, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 2938937 into patternfly:master Oct 2, 2019

patternfly-build commented Oct 2, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.112.5
  • @patternfly/react-docs@4.14.5
  • @patternfly/react-inline-edit-extension@2.11.72
  • demo-app-ts@3.6.12
  • @patternfly/react-table@2.22.21
  • @patternfly/react-topology@2.8.67
  • @patternfly/react-virtualized-extension@1.2.57

Thanks for your contribution! 🎉

tlabaj mentioned this pull request Oct 3, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

evwilkin evwilkin approved these changes
redallen Awaiting requested review from redallen
+1 more reviewer
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Documentation 📝

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL