FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(loginform): pass 'remember me' state to isChecked by boaz0 · Pull Request #3056 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(loginform): pass 'remember me' state to isChecked - #3056

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_3051
Oct 8, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(loginform): pass 'remember me' state to isChecked#3056
tlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_3051

Conversation

boaz0 commented Oct 1, 2019

Copy link
Copy Markdown
Member

What:

closes #3051

patternfly-build commented Oct 1, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3056.surge.sh

fix(loginform): pass 'remember me' state to isChecked
31bc15b 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

codecov-io commented Oct 1, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3056 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3056   +/-   ##
=======================================
  Coverage   68.93%   68.93%           
=======================================
  Files         857      857           
  Lines       23437    23437           
  Branches     1835     1835           
=======================================
  Hits        16156    16156           
  Misses       6365     6365           
  Partials      916      916
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.16% <ø> (ø) ⬆️
#patternfly4 67.98% <ø> (ø) ⬆️
Impacted Files Coverage Δ
.../react-core/src/components/LoginPage/LoginForm.tsx 51.72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af0c7aa...31bc15b. Read the comment docs.

tlabaj approved these changes Oct 8, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 3d3a0ce into patternfly:master Oct 8, 2019

patternfly-build commented Oct 8, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.113.3
  • @patternfly/react-docs@4.14.14
  • @patternfly/react-inline-edit-extension@2.11.82
  • demo-app-ts@3.6.21
  • @patternfly/react-table@2.22.31
  • @patternfly/react-topology@2.8.76
  • @patternfly/react-virtualized-extension@1.2.66

Thanks for your contribution! 🎉

boaz0 deleted the closes_3051 branch October 9, 2019 18:38

boaz0 commented Oct 9, 2019

Copy link
Copy Markdown
Member Author

🙇‍♂️ Thank you @tlabaj @dlabrecq

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remember me checkbox is not displaying properly in LoginForm

5 participants

Back | FazBrowse Home | New Git URL