FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Charts: Tooltip examples by dlabrecq · Pull Request #3061 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Charts: Tooltip examples - #3061

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
dlabrecq:3059-tooltips
Oct 3, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Charts: Tooltip examples#3061
tlabaj merged 1 commit into
patternfly:masterfrom
dlabrecq:3059-tooltips

Conversation

dlabrecq commented Oct 2, 2019 •
edited by tlabaj
Loading

Copy link
Copy Markdown
Member

Added multiple examples of how to apply tooltips. The current examples do show tooltips, but there are several different ways they can be applied. It would be best these examples were all in one place.

  • Using data labels
  • Using a Voronoi container
  • Wrapping a chart with a Tippy tooltip
  • Adding custom tooltip component to legends
  • Using CSS overflow Vs the constrainToVisibleArea prop
  • Left aligned tooltips using a theme property


#3059

codecov-io commented Oct 2, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@71eb2b9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3061   +/-   ##
=========================================
  Coverage          ?   68.93%           
=========================================
  Files             ?      857           
  Lines             ?    23437           
  Branches          ?     1835           
=========================================
  Hits              ?    16156           
  Misses            ?     6365           
  Partials          ?      916
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.16% <ø> (?)
#patternfly4 67.98% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71eb2b9...b7d13e8. Read the comment docs.

patternfly-build commented Oct 2, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3061.surge.sh

tlabaj approved these changes Oct 3, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 6639cf1 into patternfly:master Oct 3, 2019

patternfly-build commented Oct 3, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@5.0.17
  • @patternfly/react-core@3.112.9
  • @patternfly/react-docs@4.14.9
  • @patternfly/react-inline-edit-extension@2.11.77
  • demo-app-ts@3.6.16
  • @patternfly/react-table@2.22.26
  • @patternfly/react-topology@2.8.71
  • @patternfly/react-virtualized-extension@1.2.61

Thanks for your contribution! 🎉

dlabrecq deleted the 3059-tooltips branch January 15, 2020 14:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Documentation 📝

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL