FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(Spinner): Fix alert type in docs by tlabaj · Pull Request #3063 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

docs(Spinner): Fix alert type in docs - #3063

Merged
redallen merged 2 commits into
patternfly:masterfrom
tlabaj:spinnerAlert
Oct 3, 2019
ConversationCommits (2)ChecksFiles changed
Merged

docs(Spinner): Fix alert type in docs#3063
redallen merged 2 commits into
patternfly:masterfrom
tlabaj:spinnerAlert

Conversation

tlabaj commented Oct 2, 2019

Copy link
Copy Markdown
Contributor

#2986

What:

Additional issues:

tlabaj requested review from evwilkin and jessiehuff October 2, 2019 22:33

codecov-io commented Oct 2, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3063 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3063   +/-   ##
=======================================
  Coverage   68.97%   68.97%           
=======================================
  Files         857      857           
  Lines       23445    23445           
  Branches     1847     1847           
=======================================
  Hits        16171    16171           
  Misses       6357     6357           
  Partials      917      917
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (ø) ⬆️
#patternfly4 68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c862f...0f7eb6f. Read the comment docs.

patternfly-build commented Oct 2, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3063.surge.sh

evwilkin requested changes Oct 3, 2019
View reviewed changes

evwilkin left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I believe we can remove the <Alert> completely and just add this line to the frontmatter on line 7 - this is how the message has been displayed in the other Experimental components:
stage: 'early'

evwilkin approved these changes Oct 3, 2019
View reviewed changes

evwilkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

redallen merged commit 0ef3494 into patternfly:master Oct 3, 2019

patternfly-build commented Oct 3, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.112.8
  • @patternfly/react-docs@4.14.8
  • @patternfly/react-inline-edit-extension@2.11.76
  • demo-app-ts@3.6.15
  • @patternfly/react-table@2.22.25
  • @patternfly/react-topology@2.8.70
  • @patternfly/react-virtualized-extension@1.2.60

Thanks for your contribution! 🎉

tlabaj mentioned this pull request Oct 4, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

evwilkin evwilkin approved these changes
jessiehuff Awaiting requested review from jessiehuff
+1 more reviewer
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

redallen

Labels

Documentation 📝

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL