FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Charts: Responsive legend by dlabrecq · Pull Request #3067 · patternfly/patternfly-react · GitHub

Charts: Responsive legend - #3067

Merged
mturley merged 2 commits into
patternfly:masterfrom
dlabrecq:3005-responsive-legend
Oct 10, 2019
Merged

Charts: Responsive legend#3067
mturley merged 2 commits into
patternfly:masterfrom
dlabrecq:3005-responsive-legend

Conversation

dlabrecq commented Oct 3, 2019

Copy link
Copy Markdown
Member

Added support for responsive legends.

Fixes #3005

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3067.surge.sh

dlabrecq force-pushed the 3005-responsive-legend branch from 7dd0975 to 61317c9 Compare October 3, 2019 22:35

codecov-io commented Oct 3, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3067 into master will increase coverage by 0.05%.
The diff coverage is 26.47%.

@@            Coverage Diff             @@
##           master    #3067      +/-   ##
==========================================
+ Coverage   69.02%   69.07%   +0.05%     
==========================================
  Files         858      857       -1     
  Lines       23413    23457      +44     
  Branches     1853     1860       +7     
==========================================
+ Hits        16160    16203      +43     
+ Misses       6333     6310      -23     
- Partials      920      944      +24
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (ø) ⬆️
#patternfly4 68.22% <26.47%> (+0.12%) ⬆️
Impacted Files Coverage Δ
...ents/ChartDonutUtilization/ChartDonutThreshold.tsx 74.64% <ø> (+0.96%) ⬆️
...4/react-charts/src/components/ChartLegend/index.ts 100% <ø> (ø) ⬆️
...ct-charts/src/components/ChartDonut/ChartDonut.tsx 65.21% <100%> (+0.51%) ⬆️
...ct-charts/src/components/ChartPoint/ChartPoint.tsx 17.85% <12.5%> (+1.19%) ⬆️
...t-charts/src/components/ChartUtils/chart-legend.ts 32.32% <26.08%> (+21.71%) ⬆️
...ts/ChartDonutUtilization/ChartDonutUtilization.tsx 72.28% <50%> (-0.89%) ⬇️
...-charts/src/components/ChartLegend/ChartLegend.tsx 83.87% <50%> (-5.02%) ⬇️
...t-charts/src/components/ChartPoint/path-helpers.ts 3.84% <6.89%> (+1.92%) ⬆️
...nfly-4/react-charts/src/components/Chart/Chart.tsx 54.16% <60%> (-1.16%) ⬇️
.../react-charts/src/components/ChartPie/ChartPie.tsx 74.54% <60%> (-1.39%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650c823...10219ca. Read the comment docs.

dlabrecq force-pushed the 3005-responsive-legend branch 2 times, most recently from 61ae605 to c0535ad Compare October 4, 2019 01:14
dlabrecq force-pushed the 3005-responsive-legend branch from c0535ad to ef10cab Compare October 5, 2019 03:26
dlabrecq force-pushed the 3005-responsive-legend branch from ef10cab to 10219ca Compare October 6, 2019 02:13
mturley merged commit 37a4a3b into patternfly:master Oct 10, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@5.0.22

Thanks for your contribution! 🎉

dlabrecq deleted the 3005-responsive-legend branch January 15, 2020 14:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Charts: Responsive legend

6 participants


Back | FazBrowse Home | New Git URL