FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Expandable): Allow for dynamic toggle text in uncontrolled version by rebeccaalpert · Pull Request #3068 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Expandable): Allow for dynamic toggle text in uncontrolled version - #3068

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
rebeccaalpert:expandable-dynamic-uncontrolled
Oct 10, 2019
ConversationCommits (1)ChecksFiles changed
Merged

feat(Expandable): Allow for dynamic toggle text in uncontrolled version#3068
tlabaj merged 1 commit into
patternfly:masterfrom
rebeccaalpert:expandable-dynamic-uncontrolled

Conversation

rebeccaalpert commented Oct 3, 2019

Copy link
Copy Markdown
Member

Added two new props that allow user to specify collapsed and expanded toggle text for uncontrolled expandable.

Fixes #2914.

patternfly-build commented Oct 3, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3068.surge.sh

tlabaj previously approved these changes Oct 3, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

rebeccaalpert commented Oct 10, 2019

Copy link
Copy Markdown
Member Author

Adjusted variable definition in amended commit.

feat(Expandable): Allow for dynamic toggle text in uncontrolled version
541e21a 
Added two new props that allow user to specify collapsed and expanded toggle text for uncontrolled
expandable.

Fixes #2914

codecov-io commented Oct 10, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3068 into master will decrease coverage by 0.06%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master    #3068      +/-   ##
==========================================
- Coverage   69.03%   68.96%   -0.07%     
==========================================
  Files         859      857       -2     
  Lines       23454    23454              
  Branches     1863     1849      -14     
==========================================
- Hits        16191    16176      -15     
- Misses       6339     6359      +20     
+ Partials      924      919       -5
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (-0.01%) ⬇️
#patternfly4 67.99% <55.55%> (-0.12%) ⬇️
Impacted Files Coverage Δ
...eact-core/src/components/Expandable/Expandable.tsx 80.95% <55.55%> (-6.93%) ⬇️
...nfly-3/patternfly-react/src/components/Tabs/Tab.js 51.92% <0%> (-36.97%) ⬇️
...ternfly-3/react-console/src/SerialConsole/XTerm.js 25% <0%> (-2.42%) ⬇️
.../react-core/src/components/Select/SelectOption.tsx 70.96% <0%> (-0.91%) ⬇️
...y-3/patternfly-react/src/components/Table/Table.js 95.62% <0%> (-0.1%) ⬇️
...tternfly-4/react-core/src/components/Tabs/Tabs.tsx 69.35% <0%> (ø) ⬆️
...y-react-extensions/src/components/Select/Select.js 19.59% <0%> (ø) ⬆️
...fly-3/patternfly-react/src/components/Tabs/Tabs.js 32.87% <0%> (ø) ⬆️
...t-table/src/components/Table/utils/headerUtils.tsx 96.87% <0%> (ø) ⬆️
...ct-charts/src/components/ChartLabel/ChartLabel.tsx 94.73% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1607e48...541e21a. Read the comment docs.

tlabaj approved these changes Oct 10, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 3c6e4b6 into patternfly:master Oct 10, 2019

patternfly-build commented Oct 10, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.114.0
  • @patternfly/react-docs@4.14.16
  • @patternfly/react-inline-edit-extension@2.11.85
  • demo-app-ts@3.7.0
  • @patternfly/react-integration@3.7.0
  • @patternfly/react-table@2.23.1
  • @patternfly/react-topology@2.8.78
  • @patternfly/react-virtualized-extension@1.2.68

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add support for expanded vs collapsed text in Expandable uncontrolled variant

5 participants

Back | FazBrowse Home | New Git URL