FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(charts): Use markdown links by dlabrecq · Pull Request #3072 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(charts): Use markdown links - #3072

Merged
redallen merged 1 commit into
patternfly:masterfrom
dlabrecq:3071-markdown-links
Oct 9, 2019
ConversationCommits (1)ChecksFiles changed
Merged

chore(charts): Use markdown links#3072
redallen merged 1 commit into
patternfly:masterfrom
dlabrecq:3071-markdown-links

Conversation

dlabrecq commented Oct 4, 2019

Copy link
Copy Markdown
Member

Simply replaces HTML anchors in examples with markdown links

Fixes #3071

patternfly-build commented Oct 4, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3072.surge.sh

codecov-io commented Oct 4, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3072 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3072      +/-   ##
==========================================
- Coverage   69.02%   69.02%   -0.01%     
==========================================
  Files         858      858              
  Lines       23432    23430       -2     
  Branches     1859     1859              
==========================================
- Hits        16174    16172       -2     
  Misses       6337     6337              
  Partials      921      921
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (-0.01%) ⬇️
#patternfly4 68.09% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ternfly-3/react-console/src/SerialConsole/XTerm.js 25% <0%> (-2.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7313d...1fcc7b4. Read the comment docs.

jenny-s51 suggested changes Oct 5, 2019
View reviewed changes

jenny-s51 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM -- all links working as expected. Just need to fix what's addressed in the comment comment below 🙂

Comment thread packages/patternfly-4/react-charts/src/components/ChartBullet/examples/ChartBullet.md Outdated
- For `ChartLegend` props, see <a href="https://formidable.com/open-source/victory/docs/victory-legend" target="_blank">VictoryLegend</a>
- For `ChartAxis` props, see [VictoryAxis](https://formidable.com/open-source/victory/docs/victory-axis)
- For `ChartBullet` props, see [VictoryBar](https://formidable.com/open-source/victory/docs/victory-bar)
- For `ChartContainer` props, see [Victory](https://formidable.com/open-source/victory/docs/victory-container)

jenny-s51 Oct 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Did you mean to have VictoryContainer as the link text on line 877?

dlabrecq Oct 7, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch. Fixed. Thanks!

dlabrecq force-pushed the 3071-markdown-links branch from 96b3768 to 185c817 Compare October 7, 2019 15:06
dlabrecq force-pushed the 3071-markdown-links branch from 185c817 to 1fcc7b4 Compare October 9, 2019 00:53
redallen merged commit fd54afa into patternfly:master Oct 9, 2019

patternfly-build commented Oct 9, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@5.0.21

Thanks for your contribution! 🎉

dlabrecq deleted the 3071-markdown-links branch January 15, 2020 14:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kmcfaul kmcfaul approved these changes
+2 more reviewers
jenny-s51 jenny-s51 approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jessiehuff

Labels

Documentation 📝

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Charts: Use markdown links

8 participants

Back | FazBrowse Home | New Git URL