FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Properly use this.setState in components by jessiehuff · Pull Request #3075 · patternfly/patternfly-react · GitHub

Properly use this.setState in components - #3075

Merged
redallen merged 1 commit into
patternfly:masterfrom
jessiehuff:fix/setState
Oct 9, 2019
Merged

Properly use this.setState in components#3075
redallen merged 1 commit into
patternfly:masterfrom
jessiehuff:fix/setState

Conversation

Copy link
Copy Markdown
Contributor

Fixes #2822

codecov-io commented Oct 4, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3075 into master will not change coverage.
The diff coverage is 20%.

@@           Coverage Diff           @@
##           master    #3075   +/-   ##
=======================================
  Coverage   69.02%   69.02%           
=======================================
  Files         858      858           
  Lines       23413    23413           
  Branches     1853     1853           
=======================================
  Hits        16160    16160           
  Misses       6333     6333           
  Partials      920      920
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (ø) ⬆️
#patternfly4 68.08% <20%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...-4/react-core/src/components/Nav/NavExpandable.tsx 65.85% <ø> (ø) ⬆️
...tternfly-4/react-core/src/components/Page/Page.tsx 82.75% <0%> (ø) ⬆️
...react-table/src/components/Table/ActionsColumn.tsx 79.16% <0%> (ø) ⬆️
...nfly-4/react-core/src/components/Select/Select.tsx 63.33% <0%> (ø) ⬆️
...eact-core/src/components/Expandable/Expandable.tsx 87.87% <100%> (ø) ⬆️
...y-react-extensions/src/components/Select/Select.js 19.59% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650c823...a3a0ab4. Read the comment docs.

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3075.surge.sh

redallen merged commit 24f319a into patternfly:master Oct 9, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.113.4
  • @patternfly/react-docs@4.14.15
  • @patternfly/react-inline-edit-extension@2.11.83
  • demo-app-ts@3.6.22
  • @patternfly/react-integration@3.6.3
  • @patternfly/react-table@2.22.32
  • @patternfly/react-topology@2.8.77
  • @patternfly/react-virtualized-extension@1.2.67

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Properly use this.setState in components

6 participants


Back | FazBrowse Home | New Git URL