feat(eslint): add eslint-plugin-react-hooks - #3083
Merged
tlabaj merged 1 commit intoOct 16, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
* Add eslint-plugin-react-hooks so that Foreman and plugin devs will benefit from its guidance when using Hooks.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-3083.surge.sh |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #3083 +/- ##
=======================================
Coverage 69.02% 69.02%
=======================================
Files 858 858
Lines 23430 23430
Branches 1859 1859
=======================================
Hits 16172 16172
Misses 6337 6337
Partials 921 921
Continue to review full report at Codecov.
|
Sorry, something went wrong.
dlabrecq
reviewed
Oct 7, 2019
dlabrecq
previously approved these changes
Oct 9, 2019
dlabrecq
approved these changes
Oct 16, 2019
tlabaj
approved these changes
Oct 16, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This plugin checks if you're following the Rules of Hooks and is useful for anyone developing components that use React Hooks.
In Foreman we've started using Hooks, but don't yet have this rule. See this discussion with @sharvit