FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Charts: add legend examples by dlabrecq · Pull Request #3093 · patternfly/patternfly-react · GitHub

Charts: add legend examples - #3093

Merged
redallen merged 1 commit into
patternfly:masterfrom
dlabrecq:3080-legend-examples
Oct 9, 2019
Merged

Charts: add legend examples#3093
redallen merged 1 commit into
patternfly:masterfrom
dlabrecq:3080-legend-examples

Conversation

dlabrecq commented Oct 9, 2019
edited
Loading

Copy link
Copy Markdown
Member

Adds examples of how to apply various legend features.

The current examples do show legends, but there are a few different ways they can be applied. It would be best these examples were all in one place.

Fixes #3080

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3093.surge.sh

codecov-io commented Oct 9, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3093 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3093   +/-   ##
=======================================
  Coverage   69.02%   69.02%           
=======================================
  Files         858      858           
  Lines       23432    23432           
  Branches     1859     1859           
=======================================
  Hits        16174    16174           
  Misses       6337     6337           
  Partials      921      921
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.09% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7313d...ac21e8b. Read the comment docs.

dlabrecq force-pushed the 3080-legend-examples branch from cd02142 to 48aea1e Compare October 9, 2019 00:57
dlabrecq force-pushed the 3080-legend-examples branch from 48aea1e to ac21e8b Compare October 9, 2019 01:01
redallen merged commit 32f525f into patternfly:master Oct 9, 2019
dlabrecq deleted the 3080-legend-examples branch January 15, 2020 13:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Charts: Legend examples

5 participants


Back | FazBrowse Home | New Git URL