FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Select): Modifying selection outside now works by Venefilyn · Pull Request #3096 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Select): Modifying selection outside now works - #3096

Merged
tlabaj merged 2 commits into
patternfly:masterfrom
Venefilyn:fix/select-selections-update
Oct 11, 2019
ConversationCommits (2)ChecksFiles changed
Merged

fix(Select): Modifying selection outside now works#3096
tlabaj merged 2 commits into
patternfly:masterfrom
Venefilyn:fix/select-selections-update

Conversation

Venefilyn commented Oct 9, 2019

Copy link
Copy Markdown
Contributor

What: Updating selections should now properly update with typeahead variant

Additional issues: fixes #3095

patternfly-build commented Oct 9, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3096.surge.sh

codecov-io commented Oct 9, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3096 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3096      +/-   ##
==========================================
+ Coverage   69.03%   69.04%   +<.01%     
==========================================
  Files         858      858              
  Lines       23529    23527       -2     
  Branches     1875     1875              
==========================================
  Hits        16244    16244              
+ Misses       6334     6332       -2     
  Partials      951      951
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.14% <0%> (ø) ⬆️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Select/Select.tsx 60.93% <0%> (ø) ⬆️
...y-react-extensions/src/components/Select/Select.js 19.8% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d95763...948e0ca. Read the comment docs.

tlabaj approved these changes Oct 11, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj commented Oct 11, 2019

Copy link
Copy Markdown
Contributor

@spytec We can merge this once conflicts are resolved.

Venefilyn commented Oct 11, 2019

Copy link
Copy Markdown
Contributor Author

Conflict fixed :)

tlabaj merged commit bbe99f3 into patternfly:master Oct 11, 2019

patternfly-build commented Oct 11, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@5.0.23
  • @patternfly/react-core@3.114.3
  • @patternfly/react-docs@4.14.20
  • @patternfly/react-inline-edit-extension@2.11.88
  • demo-app-ts@3.7.3
  • @patternfly/react-styled-system@3.6.42
  • @patternfly/react-styles@3.5.30
  • @patternfly/react-table@2.23.4
  • @patternfly/react-tokens@2.6.33
  • @patternfly/react-topology@2.8.81
  • @patternfly/react-virtualized-extension@1.2.71
  • @patternfly/react-icons@3.14.10

Thanks for your contribution! 🎉

rkaw92 mentioned this pull request Jun 25, 2020
Closed
Venefilyn deleted the fix/select-selections-update branch November 13, 2024 12:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PF4] Changing selections value outside Select does not update correctly in Select component

6 participants

Back | FazBrowse Home | New Git URL