FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix warnings about use of deprecated lifecycle methods by KKoukiou · Pull Request #3098 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Fix warnings about use of deprecated lifecycle methods - #3098

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
KKoukiou:unsafe-lifecycle
Oct 21, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Fix warnings about use of deprecated lifecycle methods#3098
tlabaj merged 1 commit into
patternfly:masterfrom
KKoukiou:unsafe-lifecycle

Conversation

KKoukiou commented Oct 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

The above fixes where done automatically with:
$ npx react-codemod rename-unsafe-lifecycles

Relevant issue: #3170

Fix warnings about use of deprecated lifecycle methods
0996696 
The above fixes where done automatically with:
$ npx react-codemod rename-unsafe-lifecycles

codecov-io commented Oct 9, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3098 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3098   +/-   ##
=======================================
  Coverage   69.02%   69.02%           
=======================================
  Files         858      858           
  Lines       23432    23432           
  Branches     1859     1859           
=======================================
  Hits        16174    16174           
  Misses       6337     6337           
  Partials      921      921
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <100%> (ø) ⬆️
#patternfly4 68.09% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...fly-react/src/components/Slider/BootstrapSlider.js 53.84% <ø> (ø) ⬆️
...ternfly-3/react-console/src/SerialConsole/XTerm.js 27.41% <ø> (ø) ⬆️
...onents/ToastNotification/TimedToastNotification.js 57.89% <ø> (ø) ⬆️
...rc/components/VerticalNav/VerticalNavItemHelper.js 32.9% <ø> (ø) ⬆️
...rnfly-react/src/components/Pagination/Paginator.js 40.96% <ø> (ø) ⬆️
...ponents/LoginCardComponents/LoginLanguagePicker.js 55.35% <ø> (ø) ⬆️
...nents/ClassificationBanner/ClassificationBanner.js 55.35% <100%> (ø) ⬆️
...ponents/ToastNotification/ToastNotificationList.js 63.79% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7313d...0996696. Read the comment docs.

patternfly-build commented Oct 9, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3098.surge.sh

dlabrecq reviewed Oct 9, 2019
View reviewed changes

dlabrecq left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I suspect this is fine for PF3, considering it's older code.

Per the React documentation, "These methods are considered legacy and you should avoid them in new code" -- https://reactjs.org/docs/react-component.html

Can you please attach an issue for this?

tlabaj commented Oct 18, 2019

Copy link
Copy Markdown
Contributor

@KKoukiou can you please open an issue for tracking purposes and add it to the description of the PR. Thanks.

KKoukiou mentioned this pull request Oct 21, 2019
Closed
tlabaj approved these changes Oct 21, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit dbff0f1 into patternfly:master Oct 21, 2019

mturley commented Nov 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is related to #3010, I didn't realize we also had these methods in our own code (My PR #3249 will pull in the same fixes from react-bootstrap, which should resolve the rest of these warnings for us in PF3). Thanks @KKoukiou !

This was referenced Nov 4, 2019
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

dlabrecq

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL