FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(aboutmodal,wizard): append component to any element in DOM by boaz0 · Pull Request #3102 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(aboutmodal,wizard): append component to any element in DOM - #3102

Merged
jschuler merged 1 commit into
patternfly:masterfrom
boaz0:closes_2917
Oct 15, 2019
ConversationCommits (1)ChecksFiles changed
Merged

feat(aboutmodal,wizard): append component to any element in DOM#3102
jschuler merged 1 commit into
patternfly:masterfrom
boaz0:closes_2917

Conversation

boaz0 commented Oct 9, 2019

Copy link
Copy Markdown
Member

What:

closes #2917

I added appendTo to both Wizard and AboutModal.

//ping @jschuler can you have a look?

patternfly-build commented Oct 9, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3102.surge.sh

codecov-io commented Oct 9, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3102 into master will decrease coverage by 0.08%.
The diff coverage is 62.85%.

@@            Coverage Diff             @@
##           master    #3102      +/-   ##
==========================================
- Coverage   69.02%   68.94%   -0.09%     
==========================================
  Files         858      858              
  Lines       23535    23473      -62     
  Branches     1877     1863      -14     
==========================================
- Hits        16246    16184      -62     
- Misses       6336     6366      +30     
+ Partials      953      923      -30
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (-0.01%) ⬇️
#patternfly4 67.95% <62.85%> (-0.16%) ⬇️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Wizard/Wizard.tsx 54.12% <56.25%> (+0.28%) ⬆️
...eact-core/src/components/AboutModal/AboutModal.tsx 85.24% <68.42%> (-4.96%) ⬇️
...t-charts/src/components/ChartUtils/chart-legend.ts 10.6% <0%> (-21.72%) ⬇️
...nfly-react/src/components/AboutModal/AboutModal.js 47.11% <0%> (-6.15%) ⬇️
...ternfly-3/react-console/src/SerialConsole/XTerm.js 25% <0%> (-2.42%) ⬇️
...t-charts/src/components/ChartPoint/path-helpers.ts 1.92% <0%> (-1.93%) ⬇️
...ct-charts/src/components/ChartPoint/ChartPoint.tsx 16.66% <0%> (-1.2%) ⬇️
...3/patternfly-react/src/components/Wizard/Wizard.js 33.05% <0%> (-1.06%) ⬇️
...ents/ChartDonutUtilization/ChartDonutThreshold.tsx 73.68% <0%> (-0.97%) ⬇️
...e/src/components/Dropdown/InternalDropdownItem.tsx 72.46% <0%> (-0.78%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dcfb49...f6ea277. Read the comment docs.

tlabaj requested a review from jschuler October 10, 2019 14:30
dlabrecq previously approved these changes Oct 11, 2019
View reviewed changes
feat(aboutmodal,wizard): append component to any element in DOM
f6ea277 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

boaz0 commented Oct 12, 2019

Copy link
Copy Markdown
Member Author

@dlabrecq - I see the pf4 docs build fails:

WebpackError: ReferenceError: document is not defined

This is because in Gatsby document will be undefined on build

To fix this, I set the appendTo default value to null and in getElement I will return document.body if it's null. Is that OK?

jschuler merged commit ec9d5dd into patternfly:master Oct 15, 2019
boaz0 deleted the closes_2917 branch October 16, 2019 07:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
jschuler jschuler approved these changes
dlabrecq dlabrecq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jschuler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cannot render Wizard and AboutModal to specified element

5 participants

Back | FazBrowse Home | New Git URL