fix(Dropdown/Application Launcher/Options Menu): Fix unit tests and options menu - #3107
Merged
dlabrecq merged 2 commits intoOct 11, 2019
Merged
fix(Dropdown/Application Launcher/Options Menu): Fix unit tests and options menu#3107dlabrecq merged 2 commits into
dlabrecq merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Added component ID in order to fix unit tests Fixes #3029
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-3107.surge.sh |
Sorry, something went wrong.
dlabrecq
suggested changes
Oct 11, 2019
Comment thread
packages/patternfly-4/react-core/src/helpers/util.test.js
mturley
approved these changes
Oct 11, 2019
mturley
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good to me, thanks @rebeccaalpert !
Sorry, something went wrong.
dlabrecq
approved these changes
Oct 11, 2019
Copy link
Copy Markdown
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied Nicole's fix for the Options menu.
Verified that keyhandler is working as expected. Added componentID prop in order to fix failing unit tests on keyhandler due to the id being passed to the <li>.
Fixes #3029.