FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Select): use props children if custom on filter used by karelhala · Pull Request #3123 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Select): use props children if custom on filter used - #3123

Merged
kmcfaul merged 1 commit into
patternfly:masterfrom
karelhala:fix-custom-filtering
Oct 11, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(Select): use props children if custom on filter used#3123
kmcfaul merged 1 commit into
patternfly:masterfrom
karelhala:fix-custom-filtering

Conversation

karelhala commented Oct 11, 2019

Copy link
Copy Markdown
Contributor

Fixes: #3117

What:
Do not expect filtered values to be returned from onFilter function.

Fix errors when opened Select menu by omiting them from spreaded props.

Additional issues:

karelhala commented Oct 11, 2019

Copy link
Copy Markdown
Contributor Author

This is rather blocking issue for us, can we look at it with high priority? Thank you.

patternfly-build commented Oct 11, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3123.surge.sh

codecov-io commented Oct 11, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3123 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3123      +/-   ##
==========================================
- Coverage   69.03%   69.02%   -0.02%     
==========================================
  Files         858      858              
  Lines       23529    23532       +3     
  Branches     1875     1876       +1     
==========================================
- Hits        16244    16242       -2     
- Misses       6334     6337       +3     
- Partials      951      953       +2
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.09% <100%> (-0.04%) ⬇️
Impacted Files Coverage Δ
...-4/react-core/src/components/Select/SelectMenu.tsx 81.66% <100%> (+0.63%) ⬆️
...nfly-4/react-core/src/components/Select/Select.tsx 58.85% <100%> (-2.09%) ⬇️
...y-react-extensions/src/components/Select/Select.js 19.52% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7841c2f...15686e0. Read the comment docs.

dlabrecq approved these changes Oct 11, 2019
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Tested on surge and appears to work fine.

Comment thread packages/patternfly-4/react-core/src/components/Select/Select.test.tsx
kmcfaul merged commit b20a624 into patternfly:master Oct 11, 2019

patternfly-build commented Oct 11, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.114.4
  • @patternfly/react-docs@4.14.21
  • @patternfly/react-inline-edit-extension@2.11.89
  • demo-app-ts@3.7.4
  • @patternfly/react-table@2.23.5
  • @patternfly/react-topology@2.8.82
  • @patternfly/react-virtualized-extension@1.2.72

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kmcfaul kmcfaul approved these changes
tlabaj Awaiting requested review from tlabaj
redallen Awaiting requested review from redallen
jschuler Awaiting requested review from jschuler
+1 more reviewer
dlabrecq dlabrecq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

kmcfaul

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Do not expect onFilter to return filtered values

6 participants

Back | FazBrowse Home | New Git URL