FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use gatsby-theme-patternfly-org by redallen · Pull Request #3131 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Use gatsby-theme-patternfly-org - #3131

Closed
redallen wants to merge 16 commits into
patternfly:masterfrom
redallen:refactor/mdx
ConversationCommits (16)ChecksFiles changed
Closed

Use gatsby-theme-patternfly-org#3131
redallen wants to merge 16 commits into
patternfly:masterfrom
redallen:refactor/mdx

Conversation

redallen commented Oct 11, 2019

Copy link
Copy Markdown
Contributor

What: Refactor docs to work with gatsby-theme-patternfly-org.

Additional issues:

dlabrecq suggested changes Oct 12, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-charts/src/components/ChartStack/examples/ChartStack.md
## Multi-color (ordered), horizontal stacked bar chart with bottom-left aligned legend
This demonstrates an alternate way of applying tooltips using data labels
```js
```js title=Multi-color-(ordered),-horizontal-stacked-bar-chart-with-bottom-left-aligned-legend

dlabrecq Oct 12, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why do some titles have dashes instead of white space, while others do not?

dlabrecq Oct 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There are a couple examples that originally had off as Bottom-left and Multi-color -- note the intentional dash

redallen Oct 15, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

White space is not supported in code block attributes by gatsby-mdx. We use dashes and then string replace them with spaces in our gatsby-theme-patternfly-org.

Comment thread packages/patternfly-4/react-charts/src/components/ChartStack/examples/ChartStack.md
This demonstrates monthly data and responsiveness for mobile
```js
##
```js title=Monthly stacked bar chart with bottom aligned legend and responsive container

dlabrecq Oct 12, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This title has no dashes

Comment thread packages/patternfly-4/react-charts/src/components/ChartBar/examples/ChartBar.md

Note: PatternFly React charts live in its own package at [@patternfly/react-charts](https://www.npmjs.com/package/@patternfly/react-charts)!

## Introduction

dlabrecq Oct 12, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why does this chart MD file have an introduction tag, but not others? Most chart examples have a similar paragraph.

redallen Oct 15, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We should make them consistent. In our refactor we weren't very consistent.

codecov-io commented Oct 14, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3131 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3131   +/-   ##
=======================================
  Coverage   69.02%   69.02%           
=======================================
  Files         858      858           
  Lines       23535    23535           
  Branches     1877     1877           
=======================================
  Hits        16246    16246           
  Misses       6336     6336           
  Partials      953      953
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.11% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dcfb49...d9ea585. Read the comment docs.

tlabaj requested review from dgutride and jschuler October 15, 2019 15:03
tlabaj reviewed Oct 15, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you please link the issue Zack. Thanks!

redallen commented Oct 15, 2019

Copy link
Copy Markdown
Contributor Author

Closing in favor of #3146 .

redallen closed this Oct 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jschuler Awaiting requested review from jschuler
dgutride Awaiting requested review from dgutride
2 more reviewers
tlabaj tlabaj left review comments
dlabrecq dlabrecq requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

jschuler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL