FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Radio): Fix console error by tlabaj · Pull Request #3138 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Radio): Fix console error - #3138

Merged
redallen merged 2 commits into
patternfly:masterfrom
tlabaj:radio
Oct 15, 2019
ConversationCommits (2)ChecksFiles changed
Merged

fix(Radio): Fix console error#3138
redallen merged 2 commits into
patternfly:masterfrom
tlabaj:radio

Conversation

tlabaj commented Oct 14, 2019

Copy link
Copy Markdown
Contributor

#3111

What:

Additional issues:

tlabaj requested a review from dlabaj October 14, 2019 17:16

patternfly-build commented Oct 14, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3138.surge.sh

codecov-io commented Oct 14, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3138 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3138      +/-   ##
==========================================
+ Coverage   69.02%   69.08%   +0.05%     
==========================================
  Files         858      858              
  Lines       23535    23497      -38     
  Branches     1877     1869       -8     
==========================================
- Hits        16246    16233      -13     
+ Misses       6336     6316      -20     
+ Partials      953      948       -5
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.23% <100%> (+0.12%) ⬆️
Impacted Files Coverage Δ
...ernfly-4/react-core/src/components/Radio/Radio.tsx 88.88% <100%> (-0.31%) ⬇️
...e/src/components/Dropdown/InternalDropdownItem.tsx 72.46% <0%> (-0.78%) ⬇️
...-4/react-core/src/components/Select/SelectMenu.tsx 81.03% <0%> (-0.64%) ⬇️
...ly-4/react-core/src/components/Tooltip/Tooltip.tsx 84.21% <0%> (-0.28%) ⬇️
...y-react-extensions/src/components/Select/Select.js 19.59% <0%> (-0.12%) ⬇️
...patternfly-react/src/components/Tooltip/Tooltip.js 94.11% <0%> (-0.07%) ⬇️
...mponents/TopologyControlBar/TopologyControlBar.tsx 45.12% <0%> (ø) ⬆️
...nfly-4/react-core/src/components/Select/Select.tsx 63.33% <0%> (+4.47%) ⬆️
...eact-core/src/components/Expandable/Expandable.tsx 87.87% <0%> (+6.92%) ⬆️
...act-core/src/components/Tooltip/TooltipContent.tsx 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e9654...9b44e0f. Read the comment docs.

dlabaj commented Oct 14, 2019

Copy link
Copy Markdown
Contributor

@tlabaj Verified in integr8tly and the error is gone. Thanks.

tlabaj added PF4 and removed Do Not Merge labels Oct 14, 2019
tlabaj requested a review from redallen October 14, 2019 18:45
redallen merged commit 3e432b8 into patternfly:master Oct 15, 2019

patternfly-build commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.116.0
  • @patternfly/react-docs@4.14.26
  • @patternfly/react-inline-edit-extension@2.11.94
  • demo-app-ts@3.7.9
  • @patternfly/react-table@2.23.10
  • @patternfly/react-topology@2.9.4
  • @patternfly/react-virtualized-extension@1.2.77

Thanks for your contribution! 🎉

tlabaj mentioned this pull request Oct 17, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+1 more reviewer
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

redallen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL