fix(Select): add plain modifier to toggle button - #3140
Merged
dlabaj merged 1 commit intoOct 22, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-3140.surge.sh |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #3140 +/- ##
=======================================
Coverage 69.02% 69.02%
=======================================
Files 858 858
Lines 23535 23535
Branches 1877 1877
=======================================
Hits 16246 16246
Misses 6336 6336
Partials 953 953
Continue to review full report at Codecov.
|
Sorry, something went wrong.
boaz0
approved these changes
Oct 15, 2019
boaz0
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
code LGTM
Sorry, something went wrong.
dlabrecq
approved these changes
Oct 16, 2019
mcoker
approved these changes
Oct 21, 2019
mcoker
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!!
Sorry, something went wrong.
dlabaj
approved these changes
Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3128
What:
Additional issues: