FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(emptyState): remove debug message from tests by boaz0 · Pull Request #3161 · patternfly/patternfly-react · GitHub

chore(emptyState): remove debug message from tests - #3161

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
boaz0:remove_debug_from_empty_state_test
Oct 21, 2019
Merged

chore(emptyState): remove debug message from tests#3161
tlabaj merged 1 commit into
patternfly:masterfrom
boaz0:remove_debug_from_empty_state_test

Conversation

boaz0 commented Oct 18, 2019
edited
Loading

Copy link
Copy Markdown
Member

What:

small nitpick - removing unnecessary debug log in the empty state tests (that I added and forgot to remove 😱 )

issue: #3165
closes #3165

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

codecov-io commented Oct 18, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3161 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3161      +/-   ##
==========================================
- Coverage   68.98%   68.98%   -0.01%     
==========================================
  Files         858      858              
  Lines       23627    23621       -6     
  Branches     1893     1889       -4     
==========================================
- Hits        16300    16294       -6     
  Misses       6366     6366              
  Partials      961      961
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 67.93% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
...-4/react-core/src/components/withOuia/withOuia.tsx 76.92% <0%> (-1.65%) ⬇️
...ernfly-4/react-table/src/components/Table/Body.tsx 72.34% <0%> (-0.58%) ⬇️
...-4/react-table/src/components/Table/RowWrapper.tsx 77.55% <0%> (-0.45%) ⬇️
...rnfly-4/react-table/src/components/Table/Table.tsx 91.35% <0%> (ø) ⬆️
...y-3/patternfly-react/src/components/Table/Table.js 95.74% <0%> (ø) ⬆️
...omponents/Table/utils/decorators/cellHeightAuto.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a965e4...f7c3f90. Read the comment docs.

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3161.surge.sh

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 375b688 into patternfly:master Oct 21, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.117.3
  • @patternfly/react-docs@4.15.3
  • @patternfly/react-inline-edit-extension@2.12.3
  • demo-app-ts@3.7.17
  • @patternfly/react-table@2.24.3
  • @patternfly/react-topology@2.10.3
  • @patternfly/react-virtualized-extension@1.3.3

Thanks for your contribution! 🎉

boaz0 deleted the remove_debug_from_empty_state_test branch October 21, 2019 19:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove debug messages from Empty State test

5 participants


Back | FazBrowse Home | New Git URL