FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

react followup by redallen · Pull Request #3164 · patternfly/patternfly-react · GitHub

react followup - #3164

Merged
evwilkin merged 4 commits into
masterfrom
gatsby-theme-patternfly-org
Oct 21, 2019
Merged

react followup#3164
evwilkin merged 4 commits into
masterfrom
gatsby-theme-patternfly-org

Conversation

redallen commented Oct 18, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

What: Closes #3162

Preview link: https://patternfly-react-pr-gatsby-theme-patternfly-org.surge.sh

Additional issues:

Copy link
Copy Markdown

Codecov Report

Merging #3164 into master will decrease coverage by 1.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3164      +/-   ##
==========================================
- Coverage   68.98%   67.95%   -1.04%     
==========================================
  Files         858      447     -411     
  Lines       23627    10459   -13168     
  Branches     1893     1893              
==========================================
- Hits        16300     7107    -9193     
+ Misses       6366     2391    -3975     
  Partials      961      961
Flag Coverage Δ
#misc ?
#patternfly3 ?
#patternfly4 67.95% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ernfly-react/src/components/LoginPage/LoginPage.js 37.73% <0%> (-51.16%) ⬇️
...nfly-3/patternfly-react/src/components/Tabs/Tab.js 57.14% <0%> (-31.75%) ⬇️
...fly-3/patternfly-react/src/components/Form/Form.js 57.69% <0%> (-29.27%) ⬇️
...nfly-react/src/components/EmptyState/EmptyState.js 62.06% <0%> (-23.39%) ⬇️
...y-3/patternfly-react/src/components/Label/Label.js 58.33% <0%> (-21.26%) ⬇️
...3/patternfly-react/src/components/Popover/index.js 66.66% <0%> (-20.84%) ⬇️
...3/patternfly-react/src/components/Wizard/Wizard.js 12.5% <0%> (-20.56%) ⬇️
...patternfly-react/src/components/LoginPage/index.js 80.35% <0%> (-19.65%) ⬇️
...-3/patternfly-react/src/components/Wizard/index.js 80.48% <0%> (-19.52%) ⬇️
...ly-3/patternfly-react/src/components/Grid/index.js 81.81% <0%> (-18.19%) ⬇️
... and 455 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5447bb9...1642151. Read the comment docs.

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

evwilkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

evwilkin merged commit 9c341c8 into master Oct 21, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.117.1
  • @patternfly/react-docs@4.15.1
  • @patternfly/react-inline-edit-extension@2.12.1
  • demo-app-ts@3.7.15
  • @patternfly/react-table@2.24.1
  • @patternfly/react-topology@2.10.1
  • @patternfly/react-virtualized-extension@1.3.1

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix regressions from gatsby-theme-patternfly-org

5 participants


Back | FazBrowse Home | New Git URL