surround ouia check with a try catch - #3178
Merged
redallen merged 1 commit intoOct 22, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #3178 +/- ##
==========================================
- Coverage 68.99% 68.99% -0.01%
==========================================
Files 858 858
Lines 23623 23625 +2
Branches 1892 1892
==========================================
+ Hits 16299 16300 +1
- Misses 6365 6366 +1
Partials 959 959
Continue to review full report at Codecov.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-3178.surge.sh |
Sorry, something went wrong.
redallen
approved these changes
Oct 22, 2019
kmcfaul
approved these changes
Oct 22, 2019
Copy link
Copy Markdown
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add try/catch to the ouia check since there are some environments were simply checking for window.localStorage can throw a security exception